Skip to content

Conversation

@SabaPing
Copy link

@SabaPing SabaPing commented Dec 2, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 40.02%. Comparing base (6320e3c) to head (48d02b1).
Report is 221 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cluster/spec/dashboard.go 0.00% 14 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6320e3c) and HEAD (48d02b1). Click for more details.

HEAD has 112 uploads less than BASE
Flag BASE (6320e3c) HEAD (48d02b1)
cluster 37 2
dm 15 2
tiup 22 1
unittest 24 0
playground 20 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2091       +/-   ##
===========================================
- Coverage   56.75%   40.02%   -16.73%     
===========================================
  Files         313      312        -1     
  Lines       33102    33094        -8     
===========================================
- Hits        18784    13244     -5540     
- Misses      12091    18037     +5946     
+ Partials     2227     1813      -414     
Flag Coverage Δ
cluster 28.00% <0.00%> (-17.23%) ⬇️
dm 25.92% <0.00%> (-0.43%) ⬇️
playground 15.29% <0.00%> (-<0.01%) ⬇️
tiup 16.54% <0.00%> (-0.03%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot
Copy link
Member

@SabaPing: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants