Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 26, 2025

What problem does this PR solve?

close #2588

What is changed and how it works?

This upgrades usql to a slightly newer version, in case we want to do this in multiple steps

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@ti-chi-bot ti-chi-bot bot requested a review from kaaaaaaang August 26, 2025 12:15
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 26, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Aug 26, 2025

/cc @ottok @xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox August 26, 2025 12:16
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 26, 2025

@dveeden: GitHub didn't allow me to request PR reviews from the following users: ottok.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ottok @xhebox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden dveeden marked this pull request as ready for review August 26, 2025 12:16
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@ti-chi-bot ti-chi-bot bot requested a review from nexustar August 26, 2025 12:16
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-30 13:56:47.006151663 +0000 UTC m=+621298.883982617: ☑️ agreed by xhebox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update github.com/xo/usql v0.9.5 -> v0.19.x

2 participants