-
Notifications
You must be signed in to change notification settings - Fork 325
Remove usql #2596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove usql #2596
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Please upload reports for the commit 758d560 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #2596 +/- ##
==========================================
- Coverage 40.97% 40.60% -0.37%
==========================================
Files 363 363
Lines 37683 38216 +533
==========================================
+ Hits 15440 15517 +77
- Misses 20327 20781 +454
- Partials 1916 1918 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dveeden: GitHub didn't allow me to request PR reviews from the following users: ottok. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
close #2588
What is changed and how it works?
Replaces usql (which brings many indirect dependencies) with printing a line that prints the commandline options for MySQL Client.
This fixes:
tiup clientfor playground having a different behavior and experience as atiup clusteror k8s deployed cluster.We could:
mysqlCheck List
Tests
Code changes
Side effects
Related changes
Release notes: