-
Notifications
You must be signed in to change notification settings - Fork 397
Update README.md #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update README.md #1241
Conversation
|
|
@Gold240sx is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughREADME.md was updated to include a new entry describing a fully native Swift Package Manager backend adapter for UploadThing integration with Swift projects. This is a documentation-only change with no code modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
36-37: Clarify third‑party status and tweak phrasing/casingTo avoid implying official maintenance and to align style/casing, consider marking this as community‑maintained and tighten the copy.
Proposed edit:
- [Swift Package Manager (SPM) Package](https://github.com/Gold240sx/UploadThing-Swift) - - A fully native backend adapter for incorporating uploadthing in your Swift projects. + [Swift Package (SPM) — third‑party](https://github.com/Gold240sx/UploadThing-Swift) - + A community‑maintained native Swift package for integrating UploadThing uploads and deletions into Swift projects.Optional: If you maintain a “Community packages/integrations” subsection, moving this bullet there may improve clarity. Please confirm desired placement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes more sense in the docs (/docs/src/app/(docs)/uploading-files/page.mdx) thank in the readme. There is mention of the community Python adapter, probably somewhere around there.
Added my SPM Repo to integrate file uploads and deletions into native Swift applications.
Summary by CodeRabbit