fix hexedit test #9208
Open
fix hexedit test #9208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't think this test helps. If hexedit -h succeeded, the test would fail. And it doesn't understand why it failed. So a broken binary would pass this test, and an update that generated output without curses would fail it. |
Contributor
Author
|
fair enough. the real question is how do you test interactive terminal tools like this one? |
Contributor
|
With rust programs, I usually add a --version flag using sed that doesn't launch the GUI. |
Contributor
Author
|
An example? We (the package manager) add a patch and allow it to pass? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.