Skip to content

Credit Roles #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyhein wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Credit Roles #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625adfa
Credit Roles
jyhein Jul 8, 2025
d52a924
Submodule update ##jyhein/f857_credit##
jyhein Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dbscripts/xml/upgrade.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@
<migration class="PKP\migration\upgrade\v3_6_0\I4860_MigratePublicationAddCreatedAt"/>
<migration class="PKP\migration\upgrade\v3_6_0\I4860_MigratePublicationVersionSourcePublicationId"/>
<migration class="PKP\migration\upgrade\v3_6_0\I11326_UserComments"/>
<migration class="PKP\migration\upgrade\v3_6_0\I857_CreditRoles"/>
<note file="docs/release-notes/README-3.6.0" />
</upgrade>

Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 376 files
2 changes: 1 addition & 1 deletion lib/ui-library
Open in desktop
Submodule ui-library updated 5 files
+2 −0 src/components/Form/FormGroup.vue
+19 −0 src/components/Form/fields/FieldCreditRoles.mdx
+29 −0 src/components/Form/fields/FieldCreditRoles.stories.js
+139 −0 src/components/Form/fields/FieldCreditRoles.vue
+36 −0 src/components/Form/mocks/field-credit-roles.js
5 changes: 5 additions & 0 deletions pages/catalog/CatalogBookHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ public function book($args, $request)
$rorIdIcon = file_exists($rorIconPath) ? file_get_contents($rorIconPath) : '';
$templateMgr->assign('rorIdIcon', $rorIdIcon);

// Credit Role Terms
$templateMgr->assign([
'creditRoleTerms' => Repo::CreditRole()->getTerms(),
]);

// Ask robots not to index outdated versions and point to the canonical url for the latest version
if ($this->publication->getId() != $submission->getData('currentPublicationId')) {
$templateMgr->addHeader('noindex', '<meta name="robots" content="noindex">');
Expand Down
6 changes: 6 additions & 0 deletions plugins/themes/default/styles/objects/monograph_full.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@
vertical-align: middle;
}
}

.credit_roles {
display: block;
font-size: @font-sml;
line-height: @double;
}
}

.entry_details {
Expand Down
16 changes: 16 additions & 0 deletions templates/frontend/components/authors.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* @uses $editors Array List of editors for this monograph if this is an edited
* volume. Otherwise empty.
* @uses $isChapterRequest bool Is true, if a chapter landing page is requested and not a monograph landing page
* @uses $creditRoleTerms Array of translated credit role terms: roles and degrees
*}

<div class="item authors">
Expand Down Expand Up @@ -57,6 +58,21 @@
</a>
</span>
{/if}
{if $author->getData('creditRoles')}
<span class="credit_roles">
{strip}
{foreach $author->getData('creditRoles') as $credit}
<span class="value">
{$creditRoleTerms.roles[$credit.role]|escape}
{if $creditRoleTerms.degrees[$credit.degree]}
&nbsp;({$creditRoleTerms.degrees[$credit.degree]|escape})
{/if}
</span>
{if !$credit@last}{translate key="common.commaListSeparator"}{/if}
{/foreach}
{/strip}
</span>
{/if}
</div>
{/foreach}

Expand Down