Display segment filters to anyone that can see the dashboard being filtered by the segment #5935
Conversation
|
| }) | ||
| } | ||
|
|
||
| export function canExpandSegment({ |
There was a problem hiding this comment.
Sorry I don't have the full context here but in what case would the user be able to see the dashboard but not expand the segment at all?
In other words, why isn't canExpandSegment always true?
There was a problem hiding this comment.
From @metmarkosaric's comment here it seems like whenever a segment is shown to the user they should be able to expand it. So I'm questioning the need to have any conditional logic for expanding at all.
There was a problem hiding this comment.
Thanks! From my perspective, seeing the contents of a segment and expanding it to the filters bar are different actions.
Expanding puts the constituent filters on the filters bar (and in URL) which also exposes the Update | Save a copy | Delete | Close segment menu.
Of that menu, many user roles (think :public or :viewer looking at a site segment) wouldn't be able to take particular actions. We'd have to bring the messy conditions in Plausible.Segments to the FE to conditionally enable these buttons, or risk disappointing users (makes changes, clicks Save, gets 403).
Also, in Limited Views, the way I've implemented the unremovable segment in the FE wouldn't work if we allow :public role to expand the segment.
I do think it'd be good to allow anyone to expand and save a copy for example. It will be easier to do with the LV dashboard though.
|
So is that change about not displaying the red warning? |
Changes
Tests
Changelog
Documentation
Dark mode