[DO NOT MERGE] pr for sync #2

XYenChi · 2025-03-29T11:41:54Z

No description provided.

1. Port CustomOperator.def. 2. Add rounding mode. 3. Port tail policy. 4. Add intrinsic function prefix "__riscv_". 5. Fix CI.

1. Add rif-local dummy segment load store and other head file, todo: C++ decode part. 2. Update CustomOperator.def op_type. Append output and input nfields to avoid C++ part redefinition. 3. Add dummy rif codegen file

1. Fix CustomOperatore.def input_nfield part. 2. Add input tuple declaration.

Add SegStoreOperation SegLoadOperation Miscellaneous in OpAttr

…store

lazyparser

Nice (re)start.

现在有了一个同步代码的基础，要做以下的工作：

维持这个pr2不动
重新建立一个分支，拆分下，提交一个pr，不要包含 segment load store，我看看是否容易review一点
删除掉空行
删除掉脚本生成的文件
解释 rif-local 为什么需要存在
简化 build.yml
可以单独提交1个pr删除掉已经过时的测试用例（并更新构建文件）
clang-format.yml 的修改可以单独一个pr提交

lazyparser · 2025-03-29T23:48:51Z

CMakeLists.txt

 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 set(CMAKE_CXX_STANDARD 17)
-
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -v --save-temps")


调试用途的不用加入到代码中。在调用cmake的时候命令行添加即可。不要添加这个修改。

lazyparser · 2025-03-29T23:49:08Z

CMakeLists.txt

 FetchContent_Declare(
  googletest
-  URL https://github.com/google/googletest/archive/609281088cfefc76f9d0ce82e1ff6c30cc3591e5.zip
+  URL https://github.com/google/googletest/archive/refs/tags/v1.16.0.zip


如果原来的zip能work就不要修改。

lazyparser · 2025-03-29T23:49:55Z

Makefile.in

 V:=
 endif

+#qj add


作者信息体现在 git commit message 中，不要写在注释里。这是早年没有VCS版本管理工具的时候的做法。

lazyparser · 2025-03-29T23:50:39Z

Makefile.in

+|| (echo $(2) && exit 1)
 endef

+#define cmd


如果不需要了，删除掉，而不是注释掉；以后如果要恢复，用git revert。

lazyparser · 2025-03-29T23:51:22Z

.github/workflows/build.yml

+        name: built
+        path: build
+
+  test:


分成几次提交，先确保 build 阶段能正确work。test阶段先删除。

lazyparser · 2025-03-30T00:17:57Z

test/CMakeLists.txt

                  --has-policy
 )
+#qj add
+set(GCC_TOOLCHAIN_PREFIX "/home/qjivy/work/toolchain/install-rif/")


硬编码的路径不要带开发者个人信息。

另外这个 set 默认应该是空的比较好，没有则报错。

lazyparser · 2025-03-30T00:19:08Z

test/CMakeLists.txt

-set(GCC_TOOLCHAIN_PREFIX "/sifive/tools/riscv-tools/riscv64-unknown-linux-gnu-toolsuite-13.0.0-2021.11.5-x86_64-linux-redhat8")
-set(COMPILER_TOOLCHAIN_PREFIX "/sifive/tools/riscv-tools/riscv64-unknown-linux-gnu-toolsuite-13.0.0-2021.11.5-x86_64-linux-redhat8")
+set(GCC_TOOLCHAIN_PREFIX "/home/xyenchi/dragon/riscv-gnu-toolchain/rif/bin/")
+set(COMPILER_TOOLCHAIN_PREFIX "/home/xyenchi/dragon/riscv-gnu-toolchain/rif/bin/")


硬编码的路径不要带开发者个人信息。

原有的代码看起来是硬编码了 CI workers 里的信息，开源之后应该更加一般化，要求用户在调用时候命令行指定。

lazyparser · 2025-03-30T00:19:27Z

test/CMakeLists.txt

 set(FUZZ 1)
 set(NODE 20)
-set(LENGTH 500)
+set(LENGTH 50)


为什么要修改 LENGTH？

不修改会生成测试数据太长。

lazyparser · 2025-03-30T00:20:05Z

test/rules.mk

这个文件我记得是 rif-test 自动生成的。检查下如果是错误的添加的，删除掉。

lazyparser · 2025-03-30T00:20:33Z

test/testPolicy.cpp

为什么删除了这个文件？

XYenChi and others added 29 commits December 9, 2024 02:29

Port riscv-vector-fuzzing-test for rvv intrinsic v1.0.0

c22f8e5

1. Port CustomOperator.def. 2. Add rounding mode. 3. Port tail policy. 4. Add intrinsic function prefix "__riscv_". 5. Fix CI.

[NFC] Auto-commit clang-format from github action

f23d491

Remove debug message

d202bde

Fix vmv decode name

f6a5e3f

Remove maskoff

e69035f

[WIP] fix rounding mode

65e1d18

[NFC] Auto-commit clang-format from github action

62a2443

Update CustomOperator.def: Add input and output nfield parameter

bfc3aea

[WIP] Add segment load store and miscellaneous operator

477b83c

1. Add rif-local dummy segment load store and other head file, todo: C++ decode part. 2. Update CustomOperator.def op_type. Append output and input nfields to avoid C++ part redefinition. 3. Add dummy rif codegen file

[WIP]Add segment load store compute{op_type}Op.h generate script

58e40c3

1. Fix CustomOperatore.def input_nfield part. 2. Add input tuple declaration.

[WIP]Add segment load store compute{op_type}Op.h generate script

75f561c

1. Fix CustomOperatore.def input_nfield part. 2. Add input tuple declaration.

Add SegStoreOperation SegLoadOperation Miscellaneous in OpAttr

d24053c

Merge pull request #1 from Liaoshihua/develop

72002dd

Add SegStoreOperation SegLoadOperation Miscellaneous in OpAttr

[NFC] Auto-commit clang-format from github action

286fd62

Add Miscellaneous function vreinterpret generation script

e6799f6

Add Void type

81bedb3

pass input_nfields and output_nfield

4a176aa

[WIP] add tuple type nf

cde5438

Fix code format

5d77c5d

Add segment load and store attribute

b269fce

Modify to ease dev

4997514

Fix input_nfield and output_nfield generation issue

53657fe

Fix input_nfield and output_field type issue

7ea5e84

update removed SizePtr and replacing void with vs3 type segment load …

4389931

…store

Remove erroneous modifications and Add tips for use

8ca3fad

Add build CI

d39646f

Add gcc test

7968a0b

Add test CI

4f10176

[NFC] Auto-commit clang-format from github action

9f21383

lazyparser requested changes Mar 30, 2025

View reviewed changes

lazyparser changed the title ~~pr for sync~~ [DO NOT MERGE] pr for sync Mar 31, 2025

               V:=
               endif
+              #qj add

[DO NOT MERGE] pr for sync #2

Are you sure you want to change the base?

[DO NOT MERGE] pr for sync #2

Uh oh!

Conversation

XYenChi commented Mar 29, 2025

Uh oh!

lazyparser left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants