GitLab CI/CD support for cookieplone generated template #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepiercy
requested changes
May 27, 2025
templates/projects/monorepo/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
templates/projects/monorepo/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
templates/projects/monorepo/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Show resolved
Hide resolved
templates/projects/monorepo/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
templates/projects/monorepo/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
…evops/README-GITLAB.md Co-authored-by: Steve Piercy <[email protected]>
…evops/README-GITLAB.md Co-authored-by: Steve Piercy <[email protected]>
…evops/README-GITLAB.md Co-authored-by: Steve Piercy <[email protected]>
…evops/README-GITLAB.md Co-authored-by: Steve Piercy <[email protected]>
stevepiercy
requested changes
May 29, 2025
| @@ -0,0 +1 @@ | |||
| GitLab CI/CD support @erral | |||
There was a problem hiding this comment.
Suggested change
| GitLab CI/CD support @erral | |
| Added GitLab CI/CD support. @erral |
| "0": "No" | ||
| }, | ||
| "devops_gitlab_deploy": { | ||
| "__prompt__": "Add GitLab Action to Deploy this project?", |
There was a problem hiding this comment.
I don't think GitLab calls it an "Action" as GitHub does.
Suggested change
| "__prompt__": "Add GitLab Action to Deploy this project?", | |
| "__prompt__": "Add GitLab CI/CD to deploy this project?", |
|
|
||
|
|
||
| def handle_container_registry_gitlab(context: OrderedDict, output_dir: Path): | ||
| """ show a warning when using GitLab as container registry""" |
There was a problem hiding this comment.
Suggested change
| """ show a warning when using GitLab as container registry""" | |
| """Show a warning when using GitLab as container registry""" |
| ], | ||
| [ | ||
| handle_devops_gitlab_deploy, | ||
| "Remove GitLab Actions deployment files", |
There was a problem hiding this comment.
Same here.
Suggested change
| "Remove GitLab Actions deployment files", | |
| "Remove GitLab CI/CD deployment files", |
| ], | ||
| [ | ||
| handle_container_registry_gitlab, | ||
| "Remove GitLab Actions deployment files", |
There was a problem hiding this comment.
Suggested change
| "Remove GitLab Actions deployment files", | |
| "Remove GitLab CI/CD deployment files", |
…evops/README-GITLAB.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding gitlab CI/CD support back to the project generated using cookieplone.
The most complex stuff here is that GitLab container registry requires container names be / separated. I mean:
registry.gitlab.com/<organisation>/<project_slug>/backendinstead ofdocker.io/<organisation>/<projects_slug>-backendSo to achieve that, I added an
if-elseclause, which is not elegant, but I haven't found a nice way to do it.In the previous PR we discussed extracting the separator thing to a filter, but I haven't found a way to do that.[