Skip to content

Conversation

@erral
Copy link
Member

@erral erral commented May 28, 2025

Additional checks for weblate.

In some cases, there are commits from weblate done by a so called Languages add-on user.

The point is that there is no github user for such user, so commits from that user come like this to mr.roboto:

[
{
   ...
   "author": null,
   "commiter": {"login": "weblate", ...},
   ...
},
...
]

When going through that structure, our previous code added those users to the unknown list, and thus report them as unknown and require them to sign the PCA.

Now, we have generalized this check for given repos and given users, and if the real commiter information is in the list, we just ignore the checks for it.

@erral erral requested a review from fredvd May 28, 2025 15:51
@erral
Copy link
Member Author

erral commented May 29, 2025

This is wrong, I will update the PR.

@fredvd fredvd merged commit 55492fd into master May 29, 2025
3 checks passed
@fredvd fredvd deleted the erral-weblate-checks branch May 29, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants