ignore weblate, 2nd round #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional checks for weblate.
In some cases, there are commits from weblate done by a so called
Languages add-onuser.The point is that there is no github user for such user, so commits from that user come like this to mr.roboto:
[ { ... "author": null, "commiter": {"login": "weblate", ...}, ... }, ... ]When going through that structure, our previous code added those users to the
unknownlist, and thus report them as unknown and require them to sign the PCA.Now, we have generalized this check for given repos and given users, and if the real commiter information is in the list, we just ignore the checks for it.