Skip to content

Commit local change to debug issue #168 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Commit local change to debug issue #168 #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96eaa16
Commit local change to debug issue #68
fredvd May 29, 2025
5fb8ab1
format
fredvd May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/mr.roboto/src/mr/roboto/subscriber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,12 +323,19 @@ def run(self):
# check if the pull request modifies the changelog file
diff_url = self.pull_request["diff_url"]
diff_data = requests.get(diff_url)
try:
patch_data = PatchSet(
diff_data.content.splitlines(), encoding=diff_data.encoding
)
except UnicodeDecodeError:
patch_data = []
# try:
# patch_data = PatchSet(
# diff_data.content.splitlines(), encoding=diff_data.encoding
# )
# except UnicodeDecodeError:
# patch_data = []

# https://github.com/plone/mr.roboto/issues/168
patch_data = PatchSet(
diff_data.content.splitlines(), encoding=diff_data.encoding
)
if len(patch_data) == 0:
self.log("no files found on the patch")

for diff_file in patch_data:
if VALID_CHANGELOG_FILES.search(diff_file.path):
Expand Down