[Seven] sitemap #7157
Merged
[Seven] sitemap #7157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I moved the slot renderers for header and footer from 'App' to the 'publicui' layout. With this change the header and footer is on all publicui routes, not only on 'content'. |
sneridagh
reviewed
Jul 20, 2025
| <SlotRenderer name="header" content={content} location={location} /> | ||
| </header> | ||
| <SlotRenderer name="main" content={content} location={location} /> | ||
| <footer id="footer"> |
There was a problem hiding this comment.
I'd bring back the footer in here, since it's valuable for the App component itself, in case somebody wants to use it anyways. It serve its purpose in Storybook story too. To make it more obvious: we won't be using it in Seven, since the Route outlet needs to be rendered in the middle (content).
* seven: [Seven] Block editor (#7228) Field and FieldWrapper component for widgets that have no field wrapper by default (#7213) Seven separate styles (#7225) Unify Container props (#7236) Recent PR 7221 docs fixes (#7226) Updated and unified react-aria version Addons registry style loader support for cmsui.css stylesheet in addons (#7221) Unified theming and styling for Storybook (#7220) Use American Engish spelling [components] File rearrangement (#7185) Unify implementations, remove custom BreadcrumbsPrimitive (#7196) seven menu dialog popover components (#7144) Small updates to package.json and LICENSE.md (#7165)
sneridagh
added a commit
that referenced
this pull request
Jul 26, 2025
* seven: Small fixes needed for CMSUI to work with the new arrangements [Seven] sitemap (#7157) [Seven] Block editor (#7228) Field and FieldWrapper component for widgets that have no field wrapper by default (#7213) Seven separate styles (#7225) Unify Container props (#7236) Recent PR 7221 docs fixes (#7226) Updated and unified react-aria version Addons registry style loader support for cmsui.css stylesheet in addons (#7221) Unified theming and styling for Storybook (#7220) Use American Engish spelling [components] File rearrangement (#7185) Unify implementations, remove custom BreadcrumbsPrimitive (#7196) seven menu dialog popover components (#7144) Small updates to package.json and LICENSE.md (#7165) Added cmsui @search loader (#7143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6695 #6670
📚 Documentation preview 📚: https://volto--7157.org.readthedocs.build/
📚 Documentation preview 📚: https://plone-registry--7157.org.readthedocs.build/