-
-
Notifications
You must be signed in to change notification settings - Fork 841
Make sure make test runs vitest #7178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wesleybl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This can't be done in branch 18, right? |
|
This is not ready yet, it depends on updating the cookieplone-templates first |
|
Even if |
|
@wesleybl Right, because existing addons run the |
|
@davisagli Will we have one configuration for Volto 18 and another for Volto 19? Or will cookieplone remove support for Volto 18? |
|
@wesleybl My plan is to update the cookieplone-templates to use vitest for new frontend add-ons in both Volto 18 and 19. |
|
@davisagli But with this PR, |
|
@wesleybl The updated frontend addon does not use |
|
Draft of changes for cookieplone-templates: plone/cookieplone-templates#246 |
wesleybl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is necessary to resolve the conflict.
|
Volto Cookieplone failed because addons use newer versions. Volto needs to be updated. See: #7291 |
wesleybl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I resolved the conflict. Now make test runs vitest.
|
@davisagli Does this still need plone/cookieplone-templates#246 ? |
|
@davisagli We can change the |
|
This was done in #7542 |
No description provided.