Skip to content

Conversation

@davisagli
Copy link
Member

No description provided.

@davisagli davisagli requested a review from sneridagh June 6, 2025 16:53
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleybl
Copy link
Member

wesleybl commented Jun 6, 2025

This can't be done in branch 18, right?

@davisagli
Copy link
Member Author

This is not ready yet, it depends on updating the cookieplone-templates first

@wesleybl
Copy link
Member

wesleybl commented Jun 6, 2025

Even if cookieplone-templates were updated, it would still break already created addons.

@davisagli
Copy link
Member Author

@wesleybl Right, because existing addons run the test command from @plone/volto. But this PR is for Volto 19.

@wesleybl
Copy link
Member

wesleybl commented Jun 6, 2025

@davisagli Will we have one configuration for Volto 18 and another for Volto 19? Or will cookieplone remove support for Volto 18?

@davisagli
Copy link
Member Author

@wesleybl My plan is to update the cookieplone-templates to use vitest for new frontend add-ons in both Volto 18 and 19.

@wesleybl
Copy link
Member

wesleybl commented Jun 6, 2025

@davisagli But with this PR, pnpm --filter @plone/volto test will not work on both versions. Or this change will have to be made on Volto 18 as well.

@davisagli
Copy link
Member Author

@wesleybl The updated frontend addon does not use pnpm --filter @plone/volto test to run the tests.

@davisagli
Copy link
Member Author

Draft of changes for cookieplone-templates: plone/cookieplone-templates#246

Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to resolve the conflict.

@wesleybl
Copy link
Member

Volto Cookieplone failed because addons use newer versions. Volto needs to be updated. See: #7291

Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I resolved the conflict. Now make test runs vitest.

@wesleybl
Copy link
Member

@davisagli Does this still need plone/cookieplone-templates#246 ?

@wesleybl
Copy link
Member

@davisagli We can change the Makefile instead of package.json, to stop depending on plone/cookieplone-templates#246.

@davisagli
Copy link
Member Author

This was done in #7542

@davisagli davisagli closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants