Add package @volto/razzle #7542

wesleybl · 2025-10-22T22:28:29Z

It's a fork of Razzle. Razzle is no longer maintained. So with this fork, we can update versions of packages with vulnerabilities.

I used the master branch of razzle

📚 Documentation preview 📚: https://volto--7542.org.readthedocs.build/

It's a fork of Razzle. Razzle is no longer maintained. So with this fork, we can update versions of packages with vulnerabilities.

wesleybl · 2025-10-23T02:37:54Z

@davisagli @sneridagh in this case do we need to fix the lint or can we ignore it?

davisagli

in this case do we need to fix the lint or can we ignore it?

In my opinion we need to either apply the fixes, or change the lint configuration for this package so the existing code doesn't fail the checks.

davisagli · 2025-10-23T05:03:16Z

packages/volto-razzle/CHANGELOG.md

We should set up towncrier like we have for other packages

davisagli · 2025-10-23T05:04:53Z

packages/volto-razzle/config/createJestConfig.js

Do we need to keep the jest stuff, since Volto is now using vitest?

I even tried removing this file, but the cookieplone job complained. Even though it uses Volto 19, it still uses Jest on Volto 19. But I don't see a problem with keeping this file here, so it looks like the original razzle.

Another thing: Can we have this change on Volto 18?

@wesleybl is using jest in cookieplone tests? we should address that (at least in 19). I will take a look.

@wesleybl @davisagli I guess we have to merge the 19 specifics branch in cookieplone, since it stills tries to use jest in ci-test. Let's try to make that happen soon. I am working in the cypress15 upgrade, some tests are still failing. I asked for helpt to Tisha, but all hands are welcomed.

@sneridagh @davisagli I think we can merge the Volto 19 branch from cookieplone as is. What do you think?

We need to merge first: plone/cookieplone-templates#299

davisagli · 2025-10-23T05:06:44Z

packages/volto/patches/patchit.sh

I don't think we need the jest config anymore, but if we do, we should now just change it in our fork instead of applying a patch.

We first need to have vitest in cookieplone so that its job doesn't complain. After that, we can remove this patch and all Jest configuration.

@davisagli indeed, we need to move the patch to the right place in the fork, and remove the patch.

@sneridagh In fact, after we removed Jest support, we didn't need to apply the patch anywhere.

wesleybl · 2025-10-23T14:02:19Z

In my opinion we need to either apply the fixes

@davisagli fixed.

wesleybl · 2025-10-23T14:37:53Z

@davisagli Is this considered a breaking change? Could we have this in Volto 18?

davisagli · 2025-10-23T14:46:17Z

@wesleybl It's definitely a breaking change, since it requires updating babel.js and the storybook script. I wouldn't try to push it for Volto 18 unless something is actively broken with the existing razzle package.

stevepiercy

Mostly just formatting and MyST markup stuff. Otherwise LGTM! Let's make sure it builds correctly in the PR preview at https://volto--7542.org.readthedocs.build/7542/upgrade-guide/index.html#replace-razzle-with-volto-razzle-fork

docs/source/upgrade-guide/index.md

stevepiercy

Docs LGTM!

sneridagh

looks already very good!

sneridagh · 2025-10-25T07:56:54Z

docs/source/upgrade-guide/index.md

+    ```diff
+      "devDependencies": {
+    -    "razzle": "4.2.18",
+    +    "@volto/razzle": "x.x.x",


Would this be necessary in projects/add-ons? I don't think so.

I was thinking about using the old Volto project generator. But I don't think we need to worry about that anymore. I'll remove it.

sneridagh · 2025-10-25T07:58:11Z

docs/source/upgrade-guide/index.md

+3.  In most cases, you don't need to change your scripts—for example `razzle start`, `razzle build`, or `razzle test`—because the fork preserves the original CLI entrypoints.
+    If you have code that imports internal modules from the `razzle` package, for example, `require('razzle/some/path')`), then update those imports to reference `@volto/razzle` instead.
+
+4.  Search your project for any direct or indirect references to `razzle` to ensure nothing was left behind, including imports, requires, and configuration presets or plugins:


Good to mention, but I think that won't be necessary in 99% of cases. So I'd state that it's only for people that really tapped into it.

I think it would have to be changed here:

https://github.com/plone/cookieplone-templates/blob/7b543eafbdcf29a6af71ede34031053aedcb4367/templates/add-ons/frontend/%7B%7B%20cookiecutter.__folder_name%20%7D%7D/packages/%7B%7B%20cookiecutter.frontend_addon_name%20%7D%7D/babel.config.js#L3

So I think it's better to leave it.

sneridagh · 2025-10-25T07:59:20Z

packages/volto-razzle/README.md

@@ -0,0 +1,69 @@
+![repo-banner](https://user-images.githubusercontent.com/4060187/28923990-050a32d4-782e-11e7-9da7-574ce5a8b455.png)


I would add a disclaimer at the top, specifying it's a fork and the reason behind. Maintaining attibutions.

sneridagh · 2025-10-25T08:02:12Z

packages/volto-razzle/package.json

+    "webpackbar": "~4||~5"
+  },
+  "peerDependencies": {
+    "babel-preset-razzle": "4.2.18",


@wesleybl did you investigate if we will need to fork this one too? As long as I remember, this one contained all the babel deps, which will be terrible outdated too.

@sneridagh In this PR I'm only concerned about the razzle. But we'll definitely have to investigate this one too.

sneridagh · 2025-10-25T08:03:40Z

packages/volto/patches/patchit.sh

@davisagli indeed, we need to move the patch to the right place in the fork, and remove the patch.

wesleybl requested review from davisagli and sneridagh October 22, 2025 22:28

wesleybl marked this pull request as draft October 22, 2025 22:30

Add package @volto/razzle

09be085

It's a fork of Razzle. Razzle is no longer maintained. So with this fork, we can update versions of packages with vulnerabilities.

davisagli reviewed Oct 23, 2025

View reviewed changes

Fix prettier and eslint

b4ff5cc

Add release-it with towncrier

a3d9342

wesleybl added 5 commits October 23, 2025 12:36

Fix links in README.md

99f5b56

Remove links that don't work

757ede4

Fix npm version badge in README.md

d3fecd9

Add newline for better readability in README.md

9574afe

Change

cbc30b0

wesleybl marked this pull request as ready for review October 23, 2025 17:32

wesleybl requested review from davisagli and stevepiercy October 23, 2025 17:33

wesleybl added 2 commits October 23, 2025 14:36

Add upgrade note

5017871

typo

7bba45b

stevepiercy requested changes Oct 23, 2025

View reviewed changes

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved

wesleybl requested a review from stevepiercy October 23, 2025 21:16

Code review

7917169

stevepiercy approved these changes Oct 23, 2025

View reviewed changes

sneridagh reviewed Oct 25, 2025

View reviewed changes

		@@ -0,0 +1,69 @@
		![repo-banner](https://user-images.githubusercontent.com/4060187/28923990-050a32d4-782e-11e7-9da7-574ce5a8b455.png)

Uh oh!

Uh oh!

Add package @volto/razzle #7542

Are you sure you want to change the base?

Add package @volto/razzle #7542

Uh oh!

Conversation

wesleybl commented Oct 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleybl commented Oct 23, 2025

Uh oh!

davisagli left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wesleybl commented Oct 23, 2025

Uh oh!

wesleybl commented Oct 23, 2025

Uh oh!

davisagli commented Oct 23, 2025

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

sneridagh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wesleybl commented Oct 22, 2025 •

edited by github-actions bot

Loading