Refactored ButtonsWidget and AlignWidget. New blockWidth, blockAlignment and size widgets based on ButtonsWidget.
#7555
Conversation
sneridagh
changed the title
ButtonsWidget and AlignWidget. New blockWidth, blockAlignment and size widgets based on ButtonsWidget.
| */ | ||
| // import '../theme/themes/pastanaga-cms-ui/extras/cms-ui.semantic.less'; | ||
| import 'semantic-ui-less/semantic.less'; | ||
| import '@plone/components/dist/basic.css'; |
There was a problem hiding this comment.
@pnicolli we have to talk about this one.
There was a problem hiding this comment.
Yeah I noticed this one and yes we need to, this is a new problem to tackle.
There was a problem hiding this comment.
Let's also check the rendered and updated docs at:
- https://volto--7555.org.readthedocs.build/7555/reference/index.html
- https://volto--7555.org.readthedocs.build/7555/reference/widgets.html
- https://volto--7555.org.readthedocs.build/7555/upgrade-guide/index.html#alignwidget-and-buttonswidget-are-now-semantic-ui-free
- https://volto--7555.org.readthedocs.build/7555/upgrade-guide/index.html#size-blockwidth-and-blockalignment-widgets-added
| React.useEffect(() => { | ||
| if (!value && defaultValue) { | ||
| const nextValue = | ||
| typeof defaultValue === 'string' | ||
| ? normalizedActions.find(({ name }) => name === defaultValue) | ||
| ?.value ?? defaultValue | ||
| : defaultValue; | ||
|
|
||
| onChange(id, nextValue); | ||
| } | ||
| }, [defaultValue, id, normalizedActions, onChange, value]); |
There was a problem hiding this comment.
It was necessary for managing the default value... This predates the "fixed" defaults in the blocks settings, so I haven't tried if that's necessary afterwards. Also, could be that RAC takes care for you, so you don't have to now. I will take a look.
There was a problem hiding this comment.
I removed it, and refactored to use RadioGroup defaultValue instead.
| [actions], | ||
| ); | ||
|
|
||
| const selectedActionName = React.useMemo( |
There was a problem hiding this comment.
This memoization feels unnecessary to me, do you have a situation where it's needed?
There was a problem hiding this comment.
Isnt't what the compiler is doing? The machine suggested that in case the options are big (for sure it would never be...)
| [normalizedActions, value], | ||
| ); | ||
|
|
||
| const handleChange = React.useCallback( |
There was a problem hiding this comment.
This one as well, not sure it's really needed
Co-authored-by: Steve Piercy <[email protected]>
This is the first time we will use
@plone/componentsin Volto core.We decided that in Volto 19, we will allow the usage of
@plone/components.