Skip to content

Fix for JsonHeaderParse #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Fix for JsonHeaderParse #3272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e072e60
Fix for JsonHeaderParse
bcameron1231 Jun 30, 2025
84c0c70
Merge branch 'version-4' into fix/jsonheaderparser
juliemturner Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/graph/content-types/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class _ContentTypes extends _GraphCollection<IContentTypeEntity[]>{
public async addCopyFromContentTypeHub(contentTypeId: string): Promise<IContentTypeAddResult> {
const creator = ContentType(this, "addCopyFromContentTypeHub").using(JSONHeaderParse());
const result = await graphPost(creator, body({ contentTypeId }));
const pendingLocation = result?.headers?.location || null;
const pendingLocation = result?.headers?.get("location") || null;
return {
data: result.data,
contentType: (<any>this).getById(result.data.id),
Expand Down
4 changes: 2 additions & 2 deletions packages/queryable/behaviors/parsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ export function JSONHeaderParse(): TimelinePipe {
return parseBinderWithErrorCheck(async (response) => {

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
if ((response.headers.has("Content-Length") && parseFloat(response.headers.get("Content-Length")!) === 0) || response.status === 204) {
if (response.status === 204) {
return {};
}

// patch to handle cases of 200 response with no or whitespace only bodies (#487 & #545)
const txt = await response.text();
const json = txt.replace(/\s/ig, "").length > 0 ? JSON.parse(txt) : {};
return { data: { ...parseODataJSON(json) }, headers: { ...response.headers } };
return { data: { ...parseODataJSON(json) }, headers: response.headers };
});
}

Expand Down