Skip to content

Conversation

@solarobot
Copy link
Contributor

#5017
use prepareVariableLen instead so that the actual size can be determined by isNull(pos, row) in extractor.

inline void Preparator::prepare(std::size_t pos, const Poco::UUID&)
{
	//use prepareVariableLen instead so that the actual size can be determined by isNull(pos, row) in extractor.
	prepareVariableLen<char>(pos, SQL_C_BINARY, 16, DT_CHAR);
	//prepareCharArray<char, DT_CHAR_ARRAY>(pos, SQL_C_BINARY, 16, 16);
}

Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a unit test for at least one back-end.

we are currently CI-testing Oracle and SQLServer:

oracle:
image: container-registry.oracle.com/database/express:21.3.0-xe
env:
ORACLE_PWD: poco
ports:
- 1521:1521
sqlserver:
image: mcr.microsoft.com/mssql/server:2022-latest
env:
MSSQL_PID: Express
ACCEPT_EULA: Y
MSSQL_SA_PASSWORD: Pocopoco1
ports:
- 1433:1433

…ll() can properly get the actual size and check if it is null.
@solarobot solarobot force-pushed the issue5017-odbc-read-previous-rowvalue branch from f0ff90b to 79485f5 Compare September 12, 2025 10:37
@solarobot solarobot requested a review from aleks-f September 20, 2025 05:02
@solarobot
Copy link
Contributor Author

the existing unit test should be ok since there is no new logic added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants