Skip to content

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Dec 16, 2025

Remove podman install from CI and the check that the machine is running from tests

Podman is not necessary for the moment, as the tests will be done on an envtest env, which does not propagate resources to the containers provider.

#507 (comment)

@feloy feloy requested review from a team and benoitf as code owners December 16, 2025 08:55
@feloy feloy added the area/ci/e2e Run e2e tests on PR label Dec 16, 2025
@feloy feloy requested review from MarsKubeX and gastoner and removed request for a team December 16, 2025 08:55
@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

Removes Podman installation from the e2e GitHub Actions workflow (e2e-pr-check path) and removes the Podman-machine startup wait and its import from the Playwright test setup; updates the test.beforeAll signature to drop the page parameter.

Changes

Cohort / File(s) Summary
E2E workflow changes
\.github/workflows/e2e-tests.yaml
Removes the Podman installation step (the "Install Podman v5 using external action") from the e2e-pr-check job, eliminating Podman setup from that workflow path.
Playwright test update
tests/playwright/src/extension.spec.ts
Removes waitForPodmanMachineStartup import and the waitForPodmanMachineStartup(page, 80_000) call; updates test.beforeAll signature to async ({ runner, welcomePage }) (drops page).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check .github/workflows/e2e-tests.yaml for any remaining Podman references or dependent steps.
  • Verify tests/playwright/src/extension.spec.ts initializes correctly after the beforeAll signature change and that no other tests reference the removed import or wait call.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ci: remove podman install' accurately and concisely summarizes the main change in the pull request—removing Podman installation from the CI workflow.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for removing Podman installation from CI and tests with a reference to the related discussion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77d71c7 and d8b0de2.

📒 Files selected for processing (2)
  • .github/workflows/e2e-tests.yaml (0 hunks)
  • tests/playwright/src/extension.spec.ts (2 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/e2e-tests.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build / windows-2022
  • GitHub Check: Build extension OCI image
  • GitHub Check: Build / ubuntu-24.04
  • GitHub Check: Build Extension Image
  • GitHub Check: Build / macos-14
🔇 Additional comments (2)
tests/playwright/src/extension.spec.ts (2)

20-20: LGTM! Import cleanup aligns with PR objectives.

The removal of waitForPodmanMachineStartup from the import statement is consistent with the PR's goal of removing Podman dependencies from e2e tests.


51-56: Remove unused page parameter from test.beforeAll.

The page fixture parameter is not used within the beforeAll hook and can be safely removed. This simplifies the fixture declaration and reduces unnecessary parameter passing. The 80-second timeout is appropriately set for the setup phase and remains unchanged.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Philippe Martin <[email protected]>
@feloy feloy merged commit 301d89d into podman-desktop:main Dec 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci/e2e Run e2e tests on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants