fix: Solve multiple issues relating to arena mutation in SQL subqueries #25110
+126
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17381.
Closes #17056.
Closes #20732.
Turns out we had an issue with possible arena/context mutation when subqueries execute.
Fixed by introducing an
execute_isolatedfunction taking a query-executing closure that ensures the subquery gets clean state, and any state updates inside the subquery don't propagate into the original/outer context.Takes care of several outstanding issues 👍