FollowUpWidget: Group items by date #4582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the widget showed security name, and attribute name/date below it. Now, we start with showing attribute name, followed by date, and list all securities having the same attribute name and date. This saves vertical space, and clearly groups all securities having the same date attribute.
Contributor
Author
|
Related discussion: #3927 (comment) Screenshot before
Screenshot after
|
buchen
reviewed
Mar 9, 2025
Comment on lines
+153
to
+154
| this.lastDate = item.date; | ||
| this.lastAttrType = item.type; |
Member
There was a problem hiding this comment.
In your example, if there is a refresh, wouldn't it show no headline at all?
There are two items that are collated into one. In the next rundown the "lastDate" and "lastAttrType" match also the first one.
I propose to not use a member variable. For reasons of simplicity, I added a "previous" item to the method.
Contributor
Author
There was a problem hiding this comment.
In your example, if there is a refresh, wouldn't it show no headline at all?
Yeah, apparently it required to override update() method to re-initialize those vars.
I propose to not use a member variable.
Sure, if there's an easy way to avoid storing state, it's good idea. Thanks for the refactor!
Member
|
merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the widget showed security name, and attribute name/date below it. Now, we start with showing attribute name, followed by date, and list all securities having the same attribute name and date. This saves vertical space, and clearly groups all securities having the same date attribute.