-
Notifications
You must be signed in to change notification settings - Fork 31
Add 2024_Penske_Leubingen #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adding .janno file
Create 2024_Penske_KinshipLeubingen.janno
|
OK, so @SandraPenske has kindly (and heroically) filled the Janno file, including all these many many relationships! I have just added the genotype data to which Sandra pointed me. I think this is ready for review. |
|
@wolfgangaroo Could I ask you to quickly look through this package -- specifically through the .janno, the .bib and the POSEIDON.yml file? I assigned you as a reviewer, but feel free to decline. |
|
Quick note about the
I think the values then need to be multiplied by 100? I think this is an issue that is actually quite prevalent across our archives. Might be worth a batch update? Or update the schema. P.S. Actually, I think that's also the case for Endogenous, even though in most cases we report it as a 0-1 range. |
|
Hey Thiseas,
You are correct! The values have to be multiplied by 100!
They were basically just copied and pasted out of the eager output!
Thiseas C. Lamnidis ***@***.***> schrieb am Mi., 12. Feb.
2025, 01:37:
… Quick note about the Damage column. You have values between 0 and 1, yet
acccording to the janno specification This should range from 0-100.
The Damage column contains the % damage on the first position of the 5’
end for the main Shotgun library used for sequencing or capture. This is an
important statistic to verify the age of ancient DNA. In case of multiple
libraries you should report a value from the merged read alignment.
I think the values then need to be multiplied by 100?
I think this is an issue that is actually quite prevalent across our
archives. Might be worth a batch update?
—
Reply to this email directly, view it on GitHub
<#244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKRS3ILRWQSKWEVZDEREXPD2PIG2HAVCNFSM6AAAAABWMF4FPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJRGA4TQMBZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
OK good catch. I will rescale them. |
PR Checklist for a new package submission
POSEIDON.ymlconforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g.2021_Zegarac_SoutheasternEurope,2021_SeguinOrlando_BellBeakeror2021_Kivisild_MedievalEstonia.POSEIDON.ymlfile with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion,title,description,contributor,packageVersion,lastModified(see here for their definition).jannofile (for a list of available fields look here and here for more detailed documentation about them)..bibfile with the necessary literature references for each sample in the.jannofile.POSEIDON.ymlfile and there are no additional, supplementary files in the submission that are not documented there..jannoand.bibfile are all named after the package title and only differ in the file extension.POSEIDON.ymlfile is1.0.0.poseidonVersionof the package in thePOSEIDON.ymlfile is set to the latest version of the Poseidon schema.POSEIDON.ymlfile contains the corresponding checksums for the fieldsgenoFile,snpFile,indFile,jannoFileandbibFile.CHANGELOGfile or one with a single entry for version1.0.0.Publicationcolumn in the.jannofile is filled and the respective.bibfile has complete entries for the listed mentioned keys..jannofile does not include any empty columns or columns only filled withn/a..jannofile adheres to the standard order as defined in the Poseidon schema here..jannoand the.ssffiles are not fully quoted, so they only use single- or double quotes ("...",'...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno.git lfs migrate import --no-rewrite path/to/file.bed(see here).