Skip to content

Conversation

@nevrome
Copy link
Member

@nevrome nevrome commented Aug 28, 2025

This PR is part of the preparation for Poseidon v3.0.0 as specified here: poseidon-framework/poseidon-schema#93

As documented in #351 I implemented the changes to .janno and .ssf.

While doing so I noticed two minor things I wanted to change in the new schema specification: poseidon-framework/poseidon-schema@31900ef & poseidon-framework/poseidon-schema@a256a62

Adding and modifying the columns in poseidon-hs also required (or: made desirable) some minor changes in the surrounding code -- but nothing spectacular.

@nevrome nevrome requested a review from stschiff August 28, 2025 13:06
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 70.43478% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.26%. Comparing base (66d85ff) to head (b864005).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Poseidon/ColumnTypesJanno.hs 49.25% 17 Missing and 17 partials ⚠️
src/Poseidon/ColumnTypesSSF.hs 0.00% 9 Missing ⚠️
src/Poseidon/SequencingSource.hs 74.28% 7 Missing and 2 partials ⚠️
src/Poseidon/Package.hs 63.15% 3 Missing and 4 partials ⚠️
src/Poseidon/Janno.hs 93.54% 1 Missing and 5 partials ⚠️
src/Poseidon/PoseidonVersion.hs 33.33% 0 Missing and 2 partials ⚠️
src/Poseidon/ColumnTypesUtils.hs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   56.83%   57.26%   +0.42%     
==========================================
  Files          33       33              
  Lines        4993     5169     +176     
  Branches      546      550       +4     
==========================================
+ Hits         2838     2960     +122     
- Misses       1609     1659      +50     
- Partials      546      550       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stschiff
Copy link
Member

stschiff commented Sep 5, 2025

Thanks, I will take a look.

@nevrome
Copy link
Member Author

nevrome commented Dec 1, 2025

Meeting 2025/12/01: Clemens goes through this PR and documents it properly to make a review possible.

@nevrome nevrome mentioned this pull request Dec 1, 2025
@nevrome
Copy link
Member Author

nevrome commented Dec 8, 2025

This PR is pretty straight forward, actually. It just adds new columns and some special handling for the ones whose semantics change with Poseidon v3.0.0. This affects so many files because changes in the .janno columns change a lot of reference data for the golden tests.

The only interesting bit is the way _Note columns are sorted when writing .janno files.

There are still two open PRs in the schema repository that should be worked into this PR, as soon as they are merged:

When this is done, the review can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants