Skip to content

Conversation

@alicecaron
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
Fixes #3521

What kind of change does this PR introduce?

Refacto, no functionnal change. TieLine are still not able to update R and X, an error is thrown.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

  • Implementations of Branch interface should now implement getR/setR/getX/setX methods
  • Implementations of LineCharacteristics should no longer implement getR/getX methods
  • Implementations of MutableLineCharacteristics should no longer implement setR/setX methods

Other information:

@alicecaron alicecaron self-assigned this Aug 8, 2025
@alicecaron alicecaron requested a review from olperr1 August 8, 2025 13:45
@alicecaron alicecaron moved this from TODO to Waiting for review in Release 09/2025 Aug 8, 2025
@alicecaron alicecaron moved this from Waiting for review to In Progress in Release 09/2025 Aug 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

@alicecaron alicecaron marked this pull request as ready for review August 26, 2025 09:43
@alicecaron alicecaron moved this from In Progress to Waiting for review in Release 09/2025 Aug 26, 2025
@olperr1 olperr1 added the Breaking Change API is broken label Sep 30, 2025
@rolnico rolnico removed this from Release 09/2025 Oct 6, 2025
@alicecaron alicecaron moved this from TODO to Waiting for review in Release 12/2025 Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for review

Development

Successfully merging this pull request may close these issues.

Incoherence between documentation and code on IIDM Branch

4 participants