-
Notifications
You must be signed in to change notification settings - Fork 50
Remove use of univocity parsers for handling fixed-width files #3660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Rol <[email protected]>
|
I did some tests to compare the performances of this version vs main. Each test consisted of importing an IEEE-CDF test file and then exporting the model. Each operation was performed 10000 times consecutively, and the results are based on the last 9950 draws.
Thanks to the change of dependency, we could have a major gain in performances. Note: exported files have changed a bit, but they are now closer to IEEE-CDF standard. The models created from the files are however unchanged. |
Signed-off-by: Nicolas Rol <[email protected]>
|
This PR replaces #3629 and avoids using an external library |
Signed-off-by: Nicolas Rol <[email protected]>
|



Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
PowSyBl uses univocity-parsers for handling fixed-width files (parsing and writing), but this lib is abandoned since 2021.
What is the new behavior (if this is a feature change)?
PowSyBl now handles fixed-width files (parsing and writing) by itself, without using external libraries.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
The following classes have been moved from
com.powsybl.ieeecdf.modeltocom.powsybl.ieeecdf.model.elements:IeeeCdfBranchIeeeCdfBusIeeeCdfInterchangeDataIeeeCdfLossZoneIeeeCdfTieLineIeeeCdfTitleThey now extend the new abstract class
AbstractIeeeElement.The following classes have been moved from
com.powsybl.ieeecdf.modeltocom.powsybl.ieeecdf.model.conversion:BranchSideConversionBranchTypeConversionBusTypeConversionLocalDateConversionSeasonConversionThey do not extend anymore the class
com.univocity.parsers.conversions.ObjectConversion.Other information: