fix(config): use correct DD_* environment variables #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Datadog SDK requires DD_* environment variables (DD_API_KEY, DD_APP_KEY, DD_SITE) to function correctly. The previous implementation used DATADOG_* variable names which never worked. This fix changes the configuration to use the correct DD_* variable names that the Datadog SDK actually reads and uses. Breaking Change: Users must update their environment variables from DATADOG_* to DD_* naming convention. The old DATADOG_* variables were never functional. Required changes: - DATADOG_API_KEY → DD_API_KEY - DATADOG_APP_KEY → DD_APP_KEY - DATADOG_SITE → DD_SITE (optional, defaults to datadoghq.com)
jimmystridh
force-pushed
the
feat/env-var-fallback
branch
from
5b0bf69 to
5212655
Compare
jimmystridh
changed the title
Tests verify that: - DD_* environment variables work correctly with our config loader - Default site value works correctly - Missing keys raise appropriate errors Most importantly, includes a test of the Datadog SDK itself that proves DATADOG_* variables were never functional. This confirms the fix addresses a bug rather than introducing a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes environment variable configuration to use the correct
DD_*variable names required by the Datadog SDK.Problem
The current implementation uses
DATADOG_*environment variables (e.g.,DATADOG_API_KEY,DATADOG_APP_KEY), but these never worked. The Datadog SDK only recognizesDD_*environment variables.This means the server was non-functional with the documented variable names.
Solution
Changed the configuration to use the correct
DD_*environment variable names that the Datadog SDK actually reads:DD_API_KEY(required)DD_APP_KEY(required)DD_SITE(optional, defaults todatadoghq.com)Breaking Change
Testing
Tested with
DD_*environment variables and confirmed the Datadog API client successfully authenticates and makes API calls.