APS Bid Adapter: Initial Release #14255

bjoberg-amzn · 2025-12-09T21:35:51Z

Overview

APS (Amazon Publisher Services) bid adapter initial open source release.

Type of change

Description of change

(feat) Banner ad support
(feat) Video ad support
(feat) iframe user sync support
(feat) Telemetry and analytics
(docs) Integration guide

Other information

Documentation PR: APS Bid Adapter Initial Release prebid.github.io#6363

bjoberg-amzn · 2025-12-09T21:38:15Z

This pull request is pending final verification and approval from Amazon and Prebid. Please keep this comment unresolved until explicit confirmation is received to proceed with the merge.

github-actions · 2025-12-09T21:38:25Z

Tread carefully! This PR adds 6 linter warnings (possibly disabled through directives):

modules/apsBidAdapter.js (+6 warnings)

bjoberg-amzn · 2025-12-09T22:40:59Z

Tread carefully! This PR adds 6 linter warnings (possibly disabled through directives):

modules/apsBidAdapter.js (+6 warnings)

Noted, will resolve these warnings prior to merge.

patmmccann · 2025-12-11T13:39:45Z

modules/apsBidAdapter.js

+        url: endpoint,
+        data: converter.toORTB({ bidRequests, bidderRequest }),
+        options: {
+          contentType: 'application/json',


You'll need to fix this

Acknowledged, will fix.

patmmccann · 2025-12-11T13:39:30Z

modules/apsBidAdapter.js

+
+    // Validate and process impressions - fail fast on structural issues
+    if (!request.imp || !Array.isArray(request.imp)) {
+      throw new Error('Request must contain a valid impressions array');


We don't allow throws, please fix to logError

Understood, we will fix this.

patmmccann · 2025-12-11T13:43:19Z

modules/apsBidAdapter.js

+function record(eventName, data) {
+  // Check if telemetry is enabled
+  if (config.readConfig('aps.telemetry') === false) {
+    return;


We talked about your record utility falling back to a beacon? Did you decide you didn't want to fire errors or other events except in the small prevent of the time aps is there?

For this initial release, APS has decided not to fire operational metrics when APS is not on page. We have made this decision to ensure consistent monitoring with our existing systems. We plan to revisit this in our subsequent releases.

patmmccann · 2025-12-11T13:44:27Z

modules/apsBidAdapter.js

+    }
+
+    request.ext = request.ext ?? {};
+    request.ext.account = config.readConfig('aps.accountID');


Please allow this to exist on ad unit config as well

Sounds good, we will make this available.

Upon further team review, APS is updating the previous response. This feature will move to a future adapter version. A separate release ensures both integration paths are tested without risk to existing features like operational metrics. Apologies for the change and thank you for your patience.

modules/apsBidAdapter.js

patmmccann · 2025-12-11T13:49:18Z

modules/apsBidAdapter.md

+
+Connects to Amazon Publisher Services (APS) for bids.
+
+# Usage


Instructions to force a test bid from the endpoint are often very useful here

Sounds good. We will add those instructions.

patmmccann · 2025-12-11T13:51:08Z

modules/apsBidAdapter.js

+    record('getUserSyncs');
+    try {
+      const userSyncs = serverResponses.flatMap(
+        (res) => res?.body?.ext?.userSyncs ?? []


There's an opportunity to use the consent objects here

Thank you for this suggestion. The latest revision now includes client-side validation in addition to existing server-side checks.

patmmccann · 2025-12-11T13:53:00Z

modules/apsBidAdapter.js

+          (s.type === 'image' && syncOptions.pixelEnabled)
+      );
+    } catch (err) {
+      record('getUserSyncs/didError', { error: err });


This seems like another opportunity to fallback from the record when telemetry is false

dgirardi · 2025-12-11T15:41:40Z

modules/apsBidAdapter.js

+          bid.ad = `<script src="${creativeUrl}"></script>
+<script>
+  const accountID = '${accountID}';
+  window._aps = window._aps || new Map();


This looks odd to me because the creative is (usually) rendered in a separate iframe and I don't expect this to be useful there. If you're just interested in recording when the render happens, onAdRenderSucceeded runs immediately after this.

APS uses an event-driven architecture. The record statement here is not used for analytics but instead to trigger a callback in the APS creative render script (creativeUrl in the code snippet).

dgirardi · 2025-12-11T15:53:15Z

modules/apsBidAdapter.js

+      if (!doesHWExist && doesFormatExist) {
+        const { w, h } = imp.banner.format[0];
+        if (typeof w !== 'number' || typeof h !== 'number') {
+          throw new Error(


Ignoring unsuitable format / imps is better than throwing, as you may still get something you can use somewhere else in the request. It would align better with how isBidRequestValid filters out only invalid requests - this sort of validation is meant to be done there, although it doesn't work on ortb imp objects which is probably why you're doing it here.

Makes sense, we will fix this. Thanks!!

ETNOL · 2025-12-11T22:02:27Z

modules/apsBidAdapter.js

+      if (!imp.banner) {
+        return;
+      }


Hey sorry to point this out again, but just checking this short circuit is intentional. I didn't spot any related test context and it tosses out video bids.
Example request:

Appreciate the feedback. The short circuit is intended so that we only add the w and h properties to banner objects. Additional test context is now included to clarify this scenario. The test I am referring to is: "when imp array contains banner object with invalid format..."

robertrmartinez · 2025-12-12T17:41:46Z

modules/apsBidAdapter.js

+        const debugQueryChar = endpoint.includes('?') ? '&' : '?';
+        const renderMethod = config.readConfig('aps.renderMethod');
+        if (renderMethod === 'fif') {
+          endpoint += debugQueryChar + 'amzn_debug_mode=fif&amzn_debug_mode=1';


is this intended to send same query param twice with different values?

Yes! This is our way to pass multiple values for our debug scenario. We are working towards simplifying our test approach in the future.

patmmccann · 2025-12-14T15:47:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-14T15:53:10Z

modules/apsBidAdapter.js

+    let vastUrl;
+    if (bid.mtype === 2) {
+      vastUrl = bid.adm;
+      // Making sure no adm value is passed down to prevent issues with some renderers
+      delete bid.adm;


Preserve video adm to keep inline VAST playable

Video responses delete bid.adm before delegating to the ORTB converter, then set vastUrl from that removed value. When APS returns inline VAST in adm (the usual ORTB case when no nurl is provided), the converter can no longer populate vastXml, and the bid is returned with no valid video creative (a VAST XML string ends up in vastUrl). In such responses the video ad will fail to render; keep adm available to buildBidResponse so inline VAST is preserved.

Useful? React with 👍 / 👎.

👍🏼 - this was useful. We acknowledge the feedback and will resolve this in a subsequent release.

**Overview** ------------ APS (Amazon Publisher Services) bid adapter initial open source release. **Changes** ----------- - (feat) Banner ad support - (feat) Video ad support - (feat) iframe user sync support - (feat) Telemetry and analytics - (docs) Integration guide

bjoberg-amzn mentioned this pull request Dec 9, 2025

APS Bid Adapter Initial Release prebid/prebid.github.io#6363

Draft

8 tasks

bjoberg-amzn marked this pull request as draft December 9, 2025 21:37

review-assignment-bot bot requested a review from jsnellbaker December 9, 2025 21:37

ChrisHuie requested a review from dgirardi December 9, 2025 21:58

bjoberg-amzn force-pushed the apsBidAdapter/v2.0.0 branch from f084d56 to 31d2df7 Compare December 10, 2025 15:44

patmmccann self-requested a review December 11, 2025 00:01

patmmccann self-assigned this Dec 11, 2025

github-advanced-security bot found potential problems Dec 11, 2025

View reviewed changes

patmmccann reviewed Dec 11, 2025

View reviewed changes

modules/apsBidAdapter.js Show resolved Hide resolved

patmmccann reviewed Dec 11, 2025

View reviewed changes

dgirardi reviewed Dec 11, 2025

View reviewed changes

patmmccann added the feature label Dec 11, 2025

ChrisHuie requested review from gmcgrath11 and robertrmartinez and removed request for jsnellbaker December 11, 2025 19:13

ETNOL reviewed Dec 11, 2025

View reviewed changes

robertrmartinez reviewed Dec 12, 2025

View reviewed changes

chatgpt-codex-connector bot reviewed Dec 14, 2025

View reviewed changes

bjoberg-amzn added a commit to bjoberg-amzn/Prebid.js that referenced this pull request Dec 16, 2025

fix: PR prebid#14255 revisions

ada978c

bjoberg-amzn mentioned this pull request Dec 16, 2025

fix: PR #14255 revisions bjoberg-amzn/Prebid.js#1

Closed

bjoberg-amzn added a commit to bjoberg-amzn/Prebid.js that referenced this pull request Dec 17, 2025

fix: PR prebid#14255 revisions

a6bf74b

bjoberg-amzn added a commit to bjoberg-amzn/Prebid.js that referenced this pull request Dec 17, 2025

fix: PR prebid#14255 revisions

424731d

bjoberg-amzn added a commit to bjoberg-amzn/Prebid.js that referenced this pull request Dec 18, 2025

fix: PR prebid#14255 revisions

fe27c7d

bjoberg-amzn force-pushed the apsBidAdapter/v2.0.0 branch from 31d2df7 to ed90dc3 Compare December 18, 2025 21:54

bjoberg-amzn force-pushed the apsBidAdapter/v2.0.0 branch from ed90dc3 to 38db9cf Compare December 19, 2025 17:11


		Connects to Amazon Publisher Services (APS) for bids.

		# Usage

APS Bid Adapter: Initial Release #14255

Are you sure you want to change the base?

APS Bid Adapter: Initial Release #14255

Conversation

bjoberg-amzn commented Dec 9, 2025

Overview

Type of change

Description of change

Other information

Uh oh!

bjoberg-amzn commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

bjoberg-amzn commented Dec 9, 2025

Uh oh!

Check warning

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patmmccann commented Dec 14, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

patmmccann Dec 11, 2025 •

edited

Loading