-
Notifications
You must be signed in to change notification settings - Fork 399
feat: source records nameless match spec #5103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
baszalmstra
merged 15 commits into
prefix-dev:main
from
baszalmstra:source_records_nameless_match_spec
Jan 8, 2026
Merged
feat: source records nameless match spec #5103
baszalmstra
merged 15 commits into
prefix-dev:main
from
baszalmstra:source_records_nameless_match_spec
Jan 8, 2026
+3,198
−1,369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Apparently this change does require a pixi build api version bump. I will check how I can make this more backwards compatible. |
baszalmstra
commented
Jan 7, 2026
Contributor
Author
baszalmstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a self review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional matchspec fields to the source record to allow distinguishing between multiple outputs with the same package name. This is not (yet) exposed to the user but is required for
pin_subpackageto work correctly. This also introduces changes the topixi-build-typesbut they should be backwards and forward compatible.Now that Im breaking the API I also:
directoryvsdir.pin_compatible.schemarsfor the project model and verifying it doesnt change through tests.build_stringandbuild_numberto the project model.Fixes #4599
How Has This Been Tested?
Not yet, I also need to test this together with a backend that supports this.
Checklist:
schema/model.py.