Add mps support when loading model from checkpoint #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/lobster into add_mps_support
|
On the lookout for a python implementation of Flash Attention for MPS architecture, as of right now, I can't seem to find any. |
|
@etherealsunshine have you tried this out with MPS? |
|
Hi @ncfrey, so MPS gets auto-detected correctly, Flash Attention properly falls back to SDPA on MPS, and basic tensor operations work. I just tested the device detection and configuration logic directly since I don't have access to the pretrained models - but the core MPS handling works correctly. Dont have immediate plans to for training a custom model yet, so if you think thats sufficient I can add these validation tests to the tests. Let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Apple Metal Perfomance shaders when loading models from checkpoint in
UME. Addresses #180Type of Change