Skip to content

Conversation

@ShinyDragonHunter
Copy link
Contributor

Description

Redo of #1452
Description from original PR:

This is an attempt to consolidate all sprite tags into a single file, constants/sprite_tags.h. There is a common mistake made by decomp users, which is accidentally duplicating sprite tag values that are already loaded. This causes graphics or palettes to load incorrectly and can be very difficult to debug. Since sprite tags are currently defined separately in their respective files, it's easy to accidentally duplicate tags--especially within the battle systems. By laying them all out explicitly in a single file, it should be simple to determine which tags are already in-use.

With C enum support in assembly files, I thought it'd also be worthwhile having the tags be enums to make it even easier to make changes to them.

Discord contact info

ShinyDragonHunter#2440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant