-
Notifications
You must be signed in to change notification settings - Fork 789
Documented and formatted a lot of files to sync with pokeemerald #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HunarPG
wants to merge
38
commits into
pret:master
Choose a base branch
from
HunarPG:Pret_Master_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
9997d23
Removed old macros and renamed unk_8 to numTracks
HunarPG 0af8676
Document the files in asm folder present in root directory
HunarPG 70c28c7
Documented data/battle_ai_scripts.s to match Emerald
HunarPG 04a7ff8
Used DEFAULT_STAT_STAGE, MAX_STAT_STAGE and MIN_STAT_STAGE in data/ba…
HunarPG c84e526
Matched documentation of data/battle_scripts_2.s with pokeemerald
HunarPG 99e7db9
Add commented out numbers for mystery_event_script_cmd_table.s
HunarPG 576b963
Documented and formated include/constants/battle_ai.h
HunarPG c5c4187
Minor readability improvements to include/constants/battle_script_com…
HunarPG 9326cd4
Formated include/constants/battle_string_ids.h a bit better
HunarPG 7ab4c38
Formated include/constants/event_objects.h
HunarPG 40c5cd9
Add proper comments in include/constants/items.h
HunarPG 4206066
Add proper comments to include/constants/map_script.h
HunarPG 753cfa8
Renamed win0left, win0top, win0right and winbottom to wirelessWinLeft…
HunarPG 5f5f1c0
Rename GAME_STAT_FISHING_CAPTURES to GAME_STAT_FISHING_ENCOUNTERS
HunarPG 12196b3
Replace NUM_TEXT_PRINTERS with WINDOWS_MAX
HunarPG cf242fe
Added STANDARD_FRIENDSHIP constant to allow easier custom adjustments
HunarPG 4b9a00c
Properly rename eventLegal to modernFatefulEncounter
HunarPG 9beb4af
Rename STRINGID_GOTCHAPKMNCAUGHT to STRINGID_GOTCHAPKMNCAUGHTPLAYER a…
HunarPG 09c3c55
Renamed PrintMysteryGiftOrEReaderTopMenu to PrintMysteryGiftOrEReader…
HunarPG 197fc64
Sync battle anim args
HunarPG d72c9ef
Add missing TYPE_MUL_NO_EFFECT and PARTY_SIZE usage
HunarPG 8d3e326
Added missing use of gSaveBlock1Ptr->registeredItem = ITEM_NONE; in s…
HunarPG 50b7636
Add NUM_TILES_PER_METATILE constant
HunarPG 3dc1a65
Introduce NUM_BATTLE_SIDES
HunarPG ecdfcc4
Rename sListMenuItems_TradeBoard to sTradeBoardListMenuItems
HunarPG 0b5c6af
More missing constant usage
HunarPG 9712d03
Adding documentation about GFHeader
HunarPG 1d22e14
Add documentation to thunder weather effect
HunarPG 4eb5728
Added missing usage of NUM_PALS_IN_PRIMARY and NUM_PALS_TOTAL
HunarPG 677b281
Made all the gFieldEffectObjectTemplates in src/data/field_effects/fi…
HunarPG b16ec26
Converted MovementActions and gMovementActionFuncs to u8 instead of s…
HunarPG e3b2f9c
Changed static const u8 to const u8 in src/data/pokemon/item_effects.…
HunarPG 328d8d5
Converted sTMHMLearnsets to gTMHMLearnsets and static const u32 to co…
HunarPG 232eed6
Made the Requested Changes
HunarPG 476f4fa
Changed spaces to tabs
HunarPG 2ad8d98
Used correct naming convention of AI_ITEM_GUARD_SPECS used in pokefir…
HunarPG d6758c9
Improved BattleScript_ActionWatchesCarefullyLeftoverWallyPrepToThrow …
HunarPG 6fe664f
Switch back to more accurate pokefirered names in battle_scripts_2.s
HunarPG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| .ifndef GUARD_ASM_MACROS_ASM_INC | ||
| .set GUARD_ASM_MACROS_ASM_INC, 1 | ||
|
|
||
| .macro inc x | ||
| .ifndef GUARD_ASM_MACROS_ASM_INC | ||
| .set GUARD_ASM_MACROS_ASM_INC, 1 | ||
| .macro inc x:req | ||
| .set \x, \x + 1 | ||
| .endm | ||
|
|
||
| .macro enum_start x=0 | ||
| .set __enum__, \x | ||
| .endm | ||
|
|
||
| .macro enum constant | ||
| .macro enum constant:req | ||
| .equiv \constant, __enum__ | ||
| inc __enum__ | ||
| .endm | ||
|
|
||
| .endif @ GUARD_ASM_MACROS_ASM_INC | ||
| .endif @ GUARD_ASM_MACROS_ASM_INC | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.