Skip to content

Conversation

@RubyRaven6
Copy link

Aims to split the voice groups in voice_groups.inc to individual files, such as the case with pokeemerald.

@GriffinRichards
Copy link
Member

Why split the cry tables into separate files? I'd imagine if you're editing one of those tables you almost always want to edit the other, so it's convenient to have them in the same file. In terms of parity between repos, pokeemerald also has these together in the same file.

@RubyRaven6
Copy link
Author

Double checking Emerald it seems like it has the structure of having each voicegroup be its own .inc file (and even recently got another makeover by being named properly)

As for why, the compartmentalizing was much cleaner to me at least, as far as navigating goes. Navigating an enormous text file for a voicegroup rather than searching through individual voicegroup files felt much clunkier, though I understand your mileage may vary on this specifically.

@GriffinRichards
Copy link
Member

I'm referring to sound/cry_tables.inc

@RubyRaven6
Copy link
Author

Oh sorry for misreading; I was also going off of PlatinumMaster's old commit and had forgotten to check how the cry tables are structured now. I can revert that one; would still the changes to the voicegroups still be welcome?

@GriffinRichards
Copy link
Member

Sure, I don't see any reason for pokefirered to organize the voicegroups differently than pokeemerald.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants