Skip to content

WIP: Update one base size token to new dimension format ({value, unit}) — for #1230 #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chillakalyan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: Update one base size token to new dimension format ({value, unit}) — for #1230 #1270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e875d9
chore(tokens): test new dimension format on base size token (issue #1…
chillakalyan Nov 6, 2025
87f8fed
Merge branch 'main' into fix/dimension-format-beginner
chillakalyan Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
388 changes: 194 additions & 194 deletions src/tokens/base/size/size.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,196 +1,196 @@
{
"base": {
"size": {
"2": {
"$value": "2px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"4": {
"$value": "4px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"6": {
"$value": "6px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"8": {
"$value": "8px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"12": {
"$value": "12px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"16": {
"$value": "16px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"20": {
"$value": "20px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"24": {
"$value": "24px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"28": {
"$value": "28px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"32": {
"$value": "32px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"36": {
"$value": "36px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"40": {
"$value": "40px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"44": {
"$value": "44px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"48": {
"$value": "48px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"64": {
"$value": "64px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"80": {
"$value": "80px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"96": {
"$value": "96px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"112": {
"$value": "112px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
},
"128": {
"$value": "128px",
"$type": "dimension",
"$extensions": {
"org.primer.figma": {
"collection": "base/size",
"scopes": ["size", "gap"]
}
}
}
}
}
base: {
size: {
'2': {
$value: {value: '2', unit: 'px'},
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'4': {
$value: '4px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'6': {
$value: '6px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'8': {
$value: '8px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'12': {
$value: '12px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'16': {
$value: '16px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'20': {
$value: '20px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'24': {
$value: '24px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'28': {
$value: '28px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'32': {
$value: '32px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'36': {
$value: '36px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'40': {
$value: '40px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'44': {
$value: '44px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'48': {
$value: '48px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'64': {
$value: '64px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'80': {
$value: '80px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'96': {
$value: '96px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'112': {
$value: '112px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
'128': {
$value: '128px',
$type: 'dimension',
$extensions: {
'org.primer.figma': {
collection: 'base/size',
scopes: ['size', 'gap'],
},
},
},
},
},
}