-
Notifications
You must be signed in to change notification settings - Fork 56
Extend line-height values to better support Linux #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 374dc66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Design Token Diff (CSS)
|
Design Token Diff (StyleLint)
|
Design Token Diff (Figma)
|
Design Token Diff (Fallbacks)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increases the precision of two body text line-height values from 4 to 5 decimal places to fix rendering issues in VRT tests on Linux.
- Extended
text.body.lineHeight.mediumfrom1.4285to1.42857 - Extended
text.body.lineHeight.smallfrom1.6666to1.66667
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tokens/functional/typography/typography.json5 | Updated line-height precision for medium and small body text sizes |
| .changeset/large-laws-doubt.md | Added changeset documenting the patch-level change |
Comments suppressed due to low confidence (1)
src/tokens/functional/typography/typography.json5:417
- For consistency with the precision improvements made to body.lineHeight values, consider extending this line-height value to 5 decimal places (1.33333). The file also contains text.codeBlock.lineHeight at 1.5385 which could benefit from similar precision treatment if cross-platform rendering consistency is the goal.
$value: 1.3333,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Primer's VRT tests run on Linux, and we can see that the line-height is just slightly off. Adding one more digit to the value seems to fix it (tested in dotcom and primer/react)
Dotcom: https://github-a489b1074d-56576033.drafts.github.io/vrt/#?q=s:failed
Primer React: https://primer-29525c1775-13348165.drafts.github.io/vrt/#?q=s:failed