-
Notifications
You must be signed in to change notification settings - Fork 56
Improve invalid illegal tokens #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 06d8caf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Design Token Diff (CSS)
|
Design Token Diff (StyleLint)
|
Design Token Diff (Figma)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the invalid.illegal syntax tokens to use semantic color tokens instead of direct base color references. This change consolidates color override logic into the semantic token layer, improving maintainability and consistency across the design system.
Key changes:
- Replaced direct base color references with semantic tokens (
fgColor.dangerandbgColor.danger.muted) - Removed redundant local overrides that are now handled by the semantic tokens themselves
- Added changeset documenting the improvement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tokens/functional/color/syntax.json5 | Updated invalid.illegal.text and invalid.illegal.bg tokens to use semantic danger tokens and removed redundant override configurations |
| .changeset/sour-needles-prove.md | Added changeset entry documenting the improvement to invalid.illegal tokens |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Improve invalid illegal tokens
List of notable changes:
What should reviewers focus on?
Steps to test: