feat: support native .node bundling
#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll throw up some testing steps in a little bit, but spoiler alert I tested this with https://github.com/privatenumber/link when I was trying to add chokidar (which it sounds we might not want to do anyways 🙃) |
2 tasks
privatenumber
force-pushed
the
roryabraham-handleNativeNodePlugins
branch
from
2448b0f to
e5ca7d1
Compare
privatenumber
changed the title
.node bundling
|
🎉 This PR is included in version 2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏼
First PR in this repo so I'm open to feedback 🙂
This PR is pretty simple - it adds the https://github.com/danielgindi/rollup-plugin-natives rollup plugin to this repo, such that it can handle projects with dependencies that include native node modules as well as pure-JS modules.
An easy way to test this is using this branch in your npm
linkpackage.Chokidar depends on a
fseventsnative node plugin. If you add it to yourlinkpackage and use it, you'll get an error whenpnpm prepack.