- 
                Notifications
    You must be signed in to change notification settings 
- Fork 24
fix(deps): update dependency probot to v12 [security] #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            renovate
  wants to merge
  1
  commit into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
renovate/npm-probot-vulnerability
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    c22274a    to
    1c19e20      
    Compare
  
    9e7be70    to
    85130f1      
    Compare
  
    85130f1    to
    2212ad2      
    Compare
  
    2212ad2    to
    17addc5      
    Compare
  
    17addc5    to
    e40c218      
    Compare
  
    e40c218    to
    28a16ae      
    Compare
  
    28a16ae    to
    7a29d89      
    Compare
  
    7a29d89    to
    ae1d1d0      
    Compare
  
    ae1d1d0    to
    0f17191      
    Compare
  
    0f17191    to
    18f395d      
    Compare
  
    18f395d    to
    b06061d      
    Compare
  
    b06061d    to
    0f81627      
    Compare
  
    0f81627    to
    342aaea      
    Compare
  
    342aaea    to
    08daf92      
    Compare
  
    0bee69c    to
    c7a1874      
    Compare
  
    c7a1874    to
    1a73247      
    Compare
  
    1a73247    to
    1f53a9a      
    Compare
  
    1f53a9a    to
    fd0c7a3      
    Compare
  
    fd0c7a3    to
    55cf769      
    Compare
  
    55cf769    to
    6fb3ac7      
    Compare
  
    6fb3ac7    to
    485064a      
    Compare
  
    485064a    to
    f3973fa      
    Compare
  
    f3973fa    to
    56ed86e      
    Compare
  
    56ed86e    to
    a7cc8ea      
    Compare
  
    a7cc8ea    to
    ceba78a      
    Compare
  
    ceba78a    to
    b2a353f      
    Compare
  
    b2a353f    to
    d54cd66      
    Compare
  
    d54cd66    to
    4813ec8      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR contains the following updates:
^6.0.0->^12.3.3GitHub Vulnerability Alerts
CVE-2023-50728
Impact
Versions v9.26.0, v10.9.x), v11.1.x, v12.0.x all contained the code that would throw the error.
Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process.
The problem is caused by an issue with error handling in the @octokit/webhooks library because the error can be undefined in some cases.
Credit goes to @pb82 (for the early analysis) and @rh-tguittet (for discovery).
Patches
Maintenance releases for the Error being thrown by the verify method in octokit/webhooks.js
Maintenance release for the reference for octokit/webhooks.js in app.js
Maintenance release for the reference for octokit/webhooks.js in octokit.js
Maintenance release for the reference for octokit/webhooks.js in Protobot
Workarounds
It is recommend that all users upgrade to the latest version of octokit/webhooks.js or use one of the updated back ported versions.
Release Notes
probot/probot (probot)
v12.3.3Compare Source
Bug Fixes
@octokit/webhookssecurity update (#1911) (02d81f8)v12.3.2Compare Source
Bug Fixes
v12.3.1Compare Source
Bug Fixes
v12.3.0Compare Source
Features
v12.2.9Compare Source
Bug Fixes
v12.2.8Compare Source
Bug Fixes
probot receivesupport complex Probot apps (#1714) (eff5553)v12.2.7Compare Source
Bug Fixes
--base-urloption andGHE_HOST(#1719) (68c9b91)v12.2.6Compare Source
Bug Fixes
v12.2.5Compare Source
Bug Fixes
v12.2.4Compare Source
Bug Fixes
v12.2.3Compare Source
Bug Fixes
v12.2.2Compare Source
Bug Fixes
v12.2.1Compare Source
Bug Fixes
hbs(#1638) (dd9f5ae)v12.2.0Compare Source
Features
GH_ORGenvironment variable (#1606) (992b480)v12.1.4Compare Source
Bug Fixes
ApplicationFunction(#1631) (073f087)v12.1.3Compare Source
Bug Fixes
v12.1.2Compare Source
Bug Fixes
context.{repo,issue,pullRequest}(#1622) (638a3b2)v12.1.1Compare Source
Bug Fixes
v12.1.0Compare Source
Features
v12.0.0Compare Source
Features
@octokit/webhooksto v9 (#1559) (4b3ae0e)BREAKING CHANGES
@octokit/webhooksv9webhookPathoption onnew Probot({})for the webhooks middlewarev11.4.1Compare Source
Bug Fixes
baseUrlon Octokit constructor instead of Probot constructor (#1552) (453ddd2)v11.4.0Compare Source
Features
v11.3.2Compare Source
Bug Fixes
NO_SMEE_SETUPto"true"(#1544) (acd47a6)v11.3.1Compare Source
Bug Fixes
HOSTenvironment variable is set (#1538) (4d70d69)v11.3.0Compare Source
Features
v11.2.4Compare Source
Bug Fixes
server.load()(#1517) (8cc1590)v11.2.3Compare Source
Bug Fixes
v11.2.2Compare Source
Bug Fixes
v11.2.1Compare Source
Bug Fixes
@octokit/plugin-rest-endpoint-methodsto v5 (#1511) (9342caf)v11.2.0Compare Source
Features
v11.1.1Compare Source
Bug Fixes
v11.1.0Compare Source
Features
onAnyandonErrormethods from@octokit/webhooks(#1480) (9a24f9d)v11.0.6Compare Source
Bug Fixes
v11.0.5Compare Source
Bug Fixes
v11.0.4Compare Source
Bug Fixes
context.pullRequestmethod (#1461) (a5779ff)v11.0.3Compare Source
Bug Fixes
v11.0.2Compare Source
Bug Fixes
options.webhookProxyfromProbotconstructor (#1459) (01bb678)v11.0.1Compare Source
Bug Fixes
v11.0.0Compare Source
BREAKING CHANGES
For a smooth upgrade, make sure to update to the latest Probot v10 version first (
npm install probot@10), run your tests, and address all deprecation messages. Nearly all removed APIs have previously been deprecated.deprecated
context.octokit.*have been removed via@octokit/plugin-rest-endpoint-methodsv4probot.serverproperty removed. Build your own server instead usingimport { Server } from "probot"probot.load()is now asynchronous and no longer returns the instanceexpress-async-errorsis no longer used.Probotconstructor parameter no longer supported increateNodeMiddleware(app, { Probot }). Pass aprobotinstance instead:createNodeMiddleware(app, { probot })getOptions()has been removed. Use{ probot: createProbot() }insteadprobot.load(appFn)no longer acceptsappFnto be a path string. Pass the actual function instead.probot.setup()removed. Use the newServerclass instead:If you have more than one app function, combine them in a function instead
probot.start()/probot.stop()removed. Use the newServerclass instead:REDIS_URLis ignored when usingProbotconstructor. Usenew Probot({ redisConfig: redis://... })insteadProbotconstructor no longer reads environment variables. Pass options instead, orimport { createProbot } from "probot"insteadProbot.run()has been removed. Useimport { run} from "probot"insteadcontext.githubhas been removed. Usecontext.octokitinsteadcontext.eventhas been removed. Usecontext.nameinsteadapp.route()has been removed. Use thegetRouter()argument from the app function instead:(app, { getRouter }) => { ... }app.routerhas been removed. UsegetRouter()from the app function instead:(app, { getRouter }) => { ... }probot.loggerhas been removed. Useprobot.loginsteadnew Probot({ id })has been removed. Usenew Probot({ appId })insteadnew Probot({ cert })has been removed. Usenew Probot({ privateKey })insteadprobot.webhookhas been removed. Useprobot.webhooksinsteadcreateProbot(options)no longer supports any keys besidesoverrides,defaults, orenvoptions.throttleOptionshas been removed. Setoptions.OctokittoProbotOctokit.defaults({ throttle })insteadimport { Application } from probothas been removed. Useimport { Probot } from probotinstead, the APIs are the samev10.19.0Compare Source
Features
(app) => {}. Deprecate({ app, getRouter }) => {}in favor of(app, { getRouter }) => {}(#1441) (42b043e), closes /github.com/probot/probot/issues/1286#issuecomment-744094299v10.18.0Compare Source
Features
createProbot()(#1431) (d315f0c)new Probot({ appId })(a94fdca)Probot.version,Probot.defaults()(2ff5d21)run(appFn, { env })(3d90806)Serverclass when usingprobot runbinary (8a3599d)Deprecations
probot.load()(3d4b363)probot.start()/probot.stop()/probot.setup()(7a8f268)new Probot({ id })(a94fdca)Bug Fixes
[METHOD] /[PATH] [STATUS] - [NUM]ms, e.gPOST / 500 - 123ms(9d767e1)v10.17.3Compare Source
Bug Fixes
app.route()with(app) => {}app function (#1430) (d203219)v10.17.2Compare Source
Bug Fixes
GHE_HOSTdeprecation message when usingprobot runcli (#1423) (0ec5f23), closes #1422v10.17.1Compare Source
Bug Fixes
"info"(49153b8)v10.17.0Compare Source
Features
import { run } from "probot". Deprecates Probot.run() (f35b58a)new Probot({ baseUrl }). DeprecatesGHE_HOST/GHE_PROTOCOLwhen using with theProbotconstructor (7abbef7)new Probot({ logLevel }). DeprecatesLOG_LEVELwhen usingProbotconstructor (7c46218)INSTALLATION_TOKEN_TTL(dfc59fc)LOG_FORMAT,LOG_LEVEL_IN_STRING,SENTRY_DSNenvironment variables when usingProbotconstructor. Pass a custom log instance instead: (514c764)REDIS_URLenvironment variable when using with theProbotconstructor. Usenew Probot({ redisConfig: "redis://..." })instead (1dbd999)v10.16.0Compare Source
Features
@probot/get-private-key(#1414) (47d9f3a), closes #1309v10.15.0Compare Source
Features
context.octokit. Deprecatescontext.github(#1413) (0527b98)v10.14.1Compare Source
Bug Fixes
@octokit/coreto latest (#1412) (9351df4)v10.14.0Compare Source
Features
{ Application }export. Use{ Probot }instead, it has the same APIs now. (#1408) (0e52e05)v10.13.0Compare Source
Features
probot.on()/probot.receive()/probot.auth()(#1407) (1812cfe)v10.12.0Compare Source
Features
getRouterargument for app function (({ app, getRouter }) => {}) (#1406) (de3adc1)v10.11.0Compare Source
Features
(app) => {}is now({ app }) => {}(#1405) (4bfae5a)v10.10.2Compare Source
Bug Fixes
.webhooks.on("*", handler)in favor of `.webhooks.onAny(handler) (ab6fcb1)v10.10.1Compare Source
Bug Fixes
v10.10.0Compare Source
Features
octokit-auth-probot(#1392) (8ba3a8e)v10.9.5Compare Source
Bug Fixes
webhooks.onError()instead of deprecatedwebhooks.on("error", ...)(#1390) (a5b36b3)v10.9.4Compare Source
Bug Fixes
v10.9.3Compare Source
Bug Fixes
contextpassed to event handler (#1378) (05abeef), closes #r501871740v10.9.2Compare Source
Bug Fixes
@octokit/webhooks(#1374) (630d78e)v10.9.1Compare Source
Bug Fixes
options.throttlepassed to{Octokit: ProbotOctokit.defaults(options)}(#1373) (9483546)v10.9.0Compare Source
Features
new Application({ throttleOptions })(#1365) (f537204)v10.8.1Compare Source
Bug Fixes
use
@probot/octokit-plugin-configforcontext.config(#1362) (a235671)If you mocked http requests for configuration files, you will have to adapt them. Instead of returning a JSON response with a
{ content }object, wherecontentis a base64 encoded version of your raw configuration, you can now return the content without encoding directly. ExampleBefore
After
v10.8.0Compare Source
Features
v10.7.1Compare Source
Bug Fixes
v10.7.0Compare Source
Features
v10.6.0Compare Source
Features
v10.5.0Compare Source
Features
v10.4.1Compare Source
Bug Fixes
v10.4.0Compare Source
Features
v10.3.0Compare Source
Features
v10.2.0Compare Source
Features
installation.idand username to repository owner login (when present) (#1337) (4cf7de9)v10.1.5Compare Source
Bug Fixes
v10.1.4Compare Source
Bug Fixes
LOG_FORMAT=json(86c1973)v10.1.3Compare Source
Bug Fixes
../lib/private-key" error when runningprobot receive(#1332) (d671d82)v10.1.2Compare Source
Bug Fixes
v10.1.1Compare Source
v10 release notes
This is the first stable release for v10. See all breaking changes and new features at
https://github.com/probot/probot/releases/tag/v10.0.0
Bug Fixes
app.auth(installationId)returnsoctokitinstance with all required installation authentication settings (#1326) (410302f)v10.1.0Compare Source
Features
v10.0.1Compare Source
Bug Fixes
v10.0.0Compare Source
Breaking changes
@octokit/resthas been updated from v16 to v17. See release notes. Important: If you currently mockedcontext.github.*methods in your test, replace these with http mocks using nock instead, otherwise your tests will create methods that no longer exist and you will see errors in production although your tests passed. See wip/app#238 for an exampleURL parameters are now always encoded when using
context.github.*methods. For example, if you usecontext.github.repos.getContent( owner, repo, path )make sure to not encode the value forpath. Also if you were mocking http requests in your tests, replace e.g.repos/octocat/hello-world/contents/.github/config.ymlwithrepos/octocat/hello-world/contents/.github%2Fconfig.ymlrequire Node 10.21+
Logging: an object with extra information must be passed as first argument. Passing it as last argument is no longer supported.
before
after
The logging output changed. Before, probot used bunyan with all kind of hacks and customizations for its log output. Now we use pino. We still do the formatting and sending errors to Sentry in the same process, but the logic is now encapsulated in
@probot/pino. We might decouple it in future as part of making Probot more suitable for serverless/function environmentscontext.issue()now returns.issue_numberinstead of.number. Usecontext.pullRequest()foroctokit.pulls.*method calls.registry_packageevent was renamed topackageThe
probotpackage no longer exportsOctokit. UseProbotOctokitinstead.Probotno longer acceptsoptions.throttlingOptions. In order to disable throttling for testing, setoptions.OctokittoProbotOctokit.defaults({ retry: { enabled: false }, throttle: { enabled: false } }):Undocumented & untested APIs removed
probot.errorHandlerprobot.httpServerapp.log.targethas been removed.routeroption forApplicationcontructor:new Application({ router })Features
@octokit/restto v17@octokit/webhooksto v7context.pullRequest()probot.log(probot.loggeris now deprecated)probot.stop()(Replaces undocumentedprobot.httpServer)bunyanwithpinofor loggingBug Fixes
v9.15.1Compare Source
Bug Fixes
v9.15.0Compare Source
bad release, sorry
v9.14.2Compare Source
Bug Fixes
v9.14.1Compare Source
Bug Fixes
v9.14.0Compare Source
Features
v9.13.2Compare Source
Bug Fixes
v9.13.1Compare Source
v9.13.0Compare Source
Features
throttleOptionsfor Probot constructor (#1272) (ac86ffb)v9.12.0Compare Source
Features
GET /probot/statsis deprecated and will be removed in v10 (#1268) (1c31415)v9.11.7Compare Source
Bug Fixes
v9.11.6Compare Source
Bug Fixes
v9.11.5Compare Source
Bug Fixes
v9.11.4Compare Source
Bug Fixes
v9.11.3Compare Source
Bug Fixes
v9.11.2Compare Source
Bug Fixes
v9.11.1Compare Source
Bug Fixes
v9.11.0Compare Source
Features
v9.10.2Compare Source
Bug Fixes
v9.10.1Compare Source
Bug Fixes
v9.10.0Compare Source
Features
v9.9.8Compare Source
Bug Fixes
v9.9.7Compare Source
Bug Fixes
v9.9.6Compare Source
Bug Fixes
v9.9.5Compare Source
Bug Fixes
v9.9.4Compare Source
Bug Fixes
v9.9.1Compare Source
Bug Fixes
v9.9.0Compare Source
Features
v9.8.1Compare Source
Bug Fixes
publish-docsstage to Travis build (#1100) (f90057e)v9.8.0[Compare Source](https://redi
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.