Adjust host zram percentage of total memory #672
Conversation
klutchell
force-pushed
the
kyle/zram-swap
branch
from
3f0fcc0 to
a85787f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new zram service to the Docker Compose configuration to help alleviate memory pressure by compressing inactive pages. The service creates a compressed RAM disk that acts as swap space, using a configurable percentage of total system memory (defaulting to 50%) with the LZ4 compression algorithm.
- Adds a new zram service that creates compressed swap space using a percentage of total memory
- Implements configurable compression algorithm and memory percentage through environment variables
- Includes cleanup logic to disable existing swap devices and remove existing zram devices before setup
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
docker-compose.yml
Outdated
| for swap in ${swaps}; do | ||
| # Swap devices reported by /proc/swaps in the container are missing the /dev/ prefix | ||
| echo "Disabling swap device ${swap##*/}..." | ||
| swapoff /dev/${swap##*/} |
There was a problem hiding this comment.
The parameter expansion ${swap##*/} removes everything up to the last slash, but according to the comment on line 244, swap devices from /proc/swaps are already missing the /dev/ prefix. This means the expansion is unnecessary and could potentially cause issues if the swap device name contains slashes.
| swapoff /dev/${swap##*/} | |
| echo "Disabling swap device ${swap}..." | |
| swapoff /dev/${swap} |
docker-compose.yml
Outdated
| for swap in ${swaps}; do | ||
| # Swap devices reported by /proc/swaps in the container are missing the /dev/ prefix | ||
| echo "Disabling swap device ${swap##*/}..." | ||
| swapoff /dev/${swap##*/} |
There was a problem hiding this comment.
Similar to the previous line, the parameter expansion ${swap##*/} is redundant since the comment states swap devices are already missing the /dev/ prefix. This should be swapoff /dev/${swap} to avoid potential issues.
| swapoff /dev/${swap##*/} | |
| echo "Disabling swap device ${swap}..." | |
| swapoff /dev/${swap} |
klutchell
force-pushed
the
kyle/zram-swap
branch
2 times, most recently
from
fbc6f5c to
e74b13e
Compare
|
/rebase |
git-basejump
bot
force-pushed
the
kyle/zram-swap
branch
from
e74b13e to
64a2bbd
Compare
|
/rebase |
git-basejump
bot
force-pushed
the
kyle/zram-swap
branch
from
64a2bbd to
01ec4b9
Compare
|
/rebase |
git-basejump
bot
force-pushed
the
kyle/zram-swap
branch
from
01ec4b9 to
c404840
Compare
|
/rebase |
git-basejump
bot
force-pushed
the
kyle/zram-swap
branch
from
c404840 to
12c2e32
Compare
|
/rebase |
To alleviate memory pressure, increase zram to 50% or a given value of total memory at runtime. This allows the host to compress inactive pages to reduce contention. This service optionally allows for the maximum zram percentage and compression algorithm to be modified at runtime using variables. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
git-basejump
bot
force-pushed
the
kyle/zram-swap
branch
from
12c2e32 to
db505f6
Compare
Pull request was converted to draft
To alleviate memory pressure, increase zram to 50% or a given value of total memory at runtime. This allows the host to compress inactive pages to reduce contention.
This service optionally allows for the maximum zram percentage and compression algorithm to be modified at runtime using variables.
Change-type: minor
Based on: #276
See: https://balena.fibery.io/Security/Information_Security_and_Reliability_Incident/GitHub-Runners-Failure-during-vcpu-run-Out-of-memory-(os-error-12)-130