Skip to content

Conversation

@puddly
Copy link
Contributor

@puddly puddly commented Jan 8, 2026

zap-linux-arm64.zip and zap-windows-arm64.zip are created as release artifacts but they aren't usable by tooling reading apack.json (e.g. slc-cli) on ARM64 platforms. This modification allows them to be picked up automatically.

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2026

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @puddly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the apack.json configuration to include support for ARM64 Linux platforms. By adding specific entries for zap and zap-cli on linux.aarch64, it resolves an issue where release artifacts for ARM64 were not being properly recognized by dependent tooling, thereby improving compatibility and usability on these architectures.

Highlights

  • ARM64 Linux Support: Added configuration entries for zap:linux.aarch64 and zap-cli:linux.aarch64 to apack.json.
  • Tooling Compatibility: This change ensures that tooling, such as slc-cli, can correctly identify and utilize zap-linux-arm64.zip release artifacts on ARM64 Linux platforms.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the aarch64 architecture on Linux to the apack.json configuration file. The changes are straightforward, adding entries for zap:linux.aarch64 and zap-cli:linux.aarch64. These additions are consistent with the existing structure and naming conventions for other platforms in the file. This will allow tooling that consumes apack.json to correctly identify the executables for Linux ARM64 platforms. The changes look correct and address the goal described in the pull request.

@brdandu
Copy link
Collaborator

brdandu commented Jan 8, 2026

Do we need it for windows as well?

@puddly
Copy link
Contributor Author

puddly commented Jan 8, 2026

I can't test ARM windows but I assume it'll work too. Want me to roll those into this PR?

@brdandu
Copy link
Collaborator

brdandu commented Jan 8, 2026

I can't test ARM windows but I assume it'll work too. Want me to roll those into this PR?

That would be great. Thank you!

@puddly puddly changed the title Add aarch64 Linux paths to apack.json Add aarch64 paths to apack.json for Linux and Windows Jan 8, 2026
@brdandu brdandu merged commit 63a4f0b into project-chip:master Jan 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants