Native macOS Apple Silicon builds #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sticks-stuff
changed the title
NikhilNarayana
requested changes
Aug 19, 2025
Member
NikhilNarayana
left a comment
NikhilNarayana
left a comment
There was a problem hiding this comment.
i also want to understand why we're hard coding homebrew paths
Member
There was a problem hiding this comment.
i say we copy this file and leave the original alone given the scope of our changes
Member
There was a problem hiding this comment.
this comment applies to both files changed in this folder
do we need these changes or can we do without them? i'd like some justification so we can note it down and mark that we've made changes
| CMAKE_FLAGS+=" -DMACOS_CODE_SIGNING=OFF" | ||
| fi | ||
|
|
||
| if [[ "$ARCH" == 'arm64' ]]; then |
Member
There was a problem hiding this comment.
combine this block and the one on line 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/jmlee337/dolphin/tree/universalmacos14
Only change I made was to not upgrade cmake
Have been using builds from this on my Macbook M1 for the last few weeks with no issue