Test built images in e2e #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the e2e test setup to use locally built images instead of hardcoded versioned images. The changes ensure that e2e tests validate the exact images built by the Makefile, making the testing process more reliable and explicit.
- Removes hardcoded
v0.5.0image tags and replaces them with dynamically set image names - Updates the Makefile to explicitly pass built image names to the e2e test script
- Adds validation to ensure required images are present locally before running tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| e2e-test.sh | Replaces hardcoded image versions with environment variables; adds validation to ensure built images exist locally before loading them into KinD |
| Makefile | Passes explicit image names (PERF_IMAGE, WEBSERVER_IMAGE, TTFR_IMAGE, TOOL_IMAGE) as environment variables to the e2e test script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lwr20
added a commit
to lwr20/tiger-bench
that referenced
this pull request
Dec 18, 2025
* Test built images in e2e * Review markups * Fix e2e by not pulling image if we loaded it
lwr20
added a commit
that referenced
this pull request
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the images that the Makefile builds in e2e-tests