Skip to content

Conversation

@hjiawei
Copy link
Collaborator

@hjiawei hjiawei commented Dec 2, 2025

Pick #746 into the go1.25 release branch.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go toolchain from v1.25.4 to v1.25.5 and Kubernetes from v1.34.1 to v1.34.2, along with various dependent build utilities and tools to ensure compatibility with the newer versions.

  • Updates Go runtime and checksums for multiple architectures (amd64, arm64, ppc64le, s390x)
  • Updates Kubernetes and related code generation tools to v1.34.2
  • Bumps various build utilities including ginkgo, protoc, golangci-lint, and others to their latest compatible versions

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
images/calico-go-build/versions.yaml Updates Go version from 1.25.4 to 1.25.5 with new checksums for all supported architectures, and Kubernetes from 1.34.1 to 1.34.2
images/calico-go-build/Dockerfile Updates versions of dependent build utilities (containerregistry, golangci-lint, mockery, protoc, yq, ginkgo, goimports, stringer, protoc-gen-go, gotestsum, kube-openapi, gofumpt) to maintain compatibility with Go 1.25.5
go.mod Updates the go directive to 1.25.5 and golang.org/x/sys dependency to v0.38.0
go.sum Updates checksums for golang.org/x/sys v0.38.0 dependency to match go.mod changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

module github.com/projectcalico/go-build

go 1.25.2
go 1.25.5
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go directive in go.mod should only specify the major and minor version (e.g., go 1.25), not the patch version. Including the patch version 1.25.5 is non-standard. The patch version of Go used for building is specified elsewhere (in the build environment), and the go.mod directive should only reflect the minimum required major.minor version for module semantics.

Suggested change
go 1.25.5
go 1.25

Copilot uses AI. Check for mistakes.
@hjiawei
Copy link
Collaborator Author

hjiawei commented Dec 2, 2025

Builds are green but CodeQL failed to download the latest Go 1.25.5 release archive.

@hjiawei hjiawei merged commit 2724500 into go1.25 Dec 2, 2025
10 of 11 checks passed
@hjiawei hjiawei deleted the bump-go1.25.5-and-utils-go1.25 branch December 2, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants