This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Allow sunrisepoint lp for supporting usb role switch #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITT supports maximum of 32 path configs for a path. But, kernel supports upto 16 path configs. So, increase SND_SOC_TPLG_NUM_TEXTS to 32 to support 32 path configs for a path. Change-Id: Idc3bb893829e5a7a58a001fe28773257f96c11e1 Signed-off-by: Puneeth Prabhu <[email protected]> Reviewed-on: Reviewed-by: Kesapragada, Pardha Saradhi <[email protected]> Reviewed-by: Singh, Guneshwor O <[email protected]> Reviewed-by: Kale, Sanyog R <[email protected]> Tested-by: Madiwalar, MadiwalappaX <[email protected]>
FE dai links now come from the topology, so removing them from machine driver. Change-Id: I2ac610902496beecb225fc44e57be28d05fb98a7 Signed-off-by: Sameer Sharma <[email protected]> Reviewed-on: Reviewed-by: Shaik, ShahinaX <[email protected]> Reviewed-by: Prabhu, PuneethX <[email protected]> Reviewed-by: Periyasamy, SriramX <[email protected]> Reviewed-by: Gogineni, GiribabuX <[email protected]> Reviewed-by: Bozek, DominikX <[email protected]> Reviewed-by: Lewandowski, Gustaw <[email protected]> Tested-by: Madiwalar, MadiwalappaX <[email protected]>
Enabling use_tplg_pcm flag to check whether FE dais will be registered from topology during dai driver component registration for BXTP platform Change-Id: I60766088a56922e61c8010b0a587452db3db42d2 Signed-off-by: Sameer Sharma <[email protected]> Reviewed-on: Reviewed-by: Periyasamy, SriramX <[email protected]> Reviewed-by: Gogineni, GiribabuX <[email protected]> Reviewed-by: Prabhu, PuneethX <[email protected]> Reviewed-by: Bozek, DominikX <[email protected]> Reviewed-by: Lewandowski, Gustaw <[email protected]> Tested-by: Madiwalar, MadiwalappaX <[email protected]>
Since there are multiple IPCs being sent in a short span of time, there is a possibility of more than one message being on the Rx list after receiving response from firmware. In such cases, when the first notification of interrupt from firmware is received, driver retrieves the message from the Rx list but does not delete it from the list till the next lock. In the meantime, when another interrupt is received from the firmware, driver is reading the previous message again since the previous message has not been removed from the list. Change-Id: I3d85cce7b0e9632a73e286d7d42a2627c1431d6e Reviewed-on: Tested-by: Lewandowski, Gustaw <[email protected]> Reviewed-by: Wasko, Michal <[email protected]>
Change-Id: I5666ca1fca1ca80e9b431138470f4d9693ff011b Signed-off-by: Amadeusz Sławiński <[email protected]> Reviewed-on: Reviewed-by: Bozek, DominikX <[email protected]> Reviewed-by: Lewandowski, Gustaw <[email protected]> Reviewed-by: Rojewski, Cezary <[email protected]> Tested-by: Rojewski, Cezary <[email protected]>
This reverts commit 640a66de27627b1f18270497d8e16fec7c9afb58. Since correspondig changes to alsa-lib is not properly upstreamed we should not introduce such change without ensure backward compatibility. Change-Id: I512b63b0e4dc7bbd889503a560c373c9e396326e Reviewed-on: Reviewed-by: Slawinski, AmadeuszX <[email protected]> Reviewed-by: Bozek, DominikX <[email protected]> Reviewed-by: Rojewski, Cezary <[email protected]> Tested-by: Rojewski, Cezary <[email protected]>
Due to unconditional initial timeouts, firmware may fail to load during its initialization. This issue cannot be resolved on driver side but has to be accounted for nonetheless. Default firmware load retry count is set to 3. Change-Id: Idd12483e07633d1f809cdc4363fb51f5217233ad Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Slawinski, AmadeuszX <[email protected]> Reviewed-by: Lewandowski, Gustaw <[email protected]> Tested-by: Lewandowski, Gustaw <[email protected]>
…ent" This reverts commit 88088a3e6a6c379b069241176f5c4f1c8573f85c. As an impact of above commit, dummy widget gets added to the widget list which leads to creation of DAI link between dummy widget and the FE DAI widget. As a result, skl_tplg_fe_get_cpr_module() returns an invalid module config pointer which leads to crash. Reverting the above commit will avoid adding a dummy widget to the widget list. Change-Id: I3d41fc776806185d9040dae695dbc258989be863 Signed-off-by: Puneeth Prabhu <[email protected]> Reviewed-on: Reviewed-by: Pawse, GuruprasadX <[email protected]> Reviewed-by: Kale, Sanyog R <[email protected]> Tested-by: Madiwalar, MadiwalappaX <[email protected]>
File skl-tplg-interface.h no longer present, relocated to uapi. Removal of duplicate declaration for skl_dai_load within skl-topology.h. Signed-off-by: Cezary Rojewski <[email protected]>
Align with machine-drv-tables declaration model present on upstream. Tables are moved from skl.c into separate file within common directory dedicated to bxt-specific data only. Change-Id: I6780bcd1506709757e673130ffc0ce6d0b26709f Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Uzieblo, Olgierd <[email protected]>
Align with machine-drv-tables declaration model present on upstream. Tables are moved from skl.c into separate file within common directory dedicated to kbl-specific data only. Change-Id: I25846b83d6c791c7c7dae25766a06beddd686277 Depends-On: I6780bcd1506709757e673130ffc0ce6d0b26709f Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Uzieblo, Olgierd <[email protected]>
Align with machine drv tables declaration model present on upstream. Tables are moved from skl.c into separate file within common directory dedicated to skl-specific data only. Change-Id: Ia7c823611f6e0f14a94447399cdcafe9aeb5e51e Depends-On: I25846b83d6c791c7c7dae25766a06beddd686277 Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Uzieblo, Olgierd <[email protected]>
Align with machine-drv-tables declaration model present on upstream. Tables are moved from skl.c into separate file within common directory dedicated to glk-specific data only. Change-Id: I3c2c0ee4eeffddb495dfd765788b9cc861e7741e Depends-On: Ia7c823611f6e0f14a94447399cdcafe9aeb5e51e Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Uzieblo, Olgierd <[email protected]>
Align with machine-drv-tables declaration model present on upstream. Tables are moved from skl.c into separate file within common directory dedicated to icl-specific data only. Change-Id: I67ead17edb1bc469894a053e7d85b67409eeb2e6 Depends-On: I3c2c0ee4eeffddb495dfd765788b9cc861e7741e Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Uzieblo, Olgierd <[email protected]>
Align with machine-drv-tables declaration model present on upstream. Tables are moved from skl.c into separate file within common directory dedicated to cnl-specific data only. Change-Id: I9bccf434c9a1d7949e88d0ab363e28c1bd193e75 Depends-On: I67ead17edb1bc469894a053e7d85b67409eeb2e6 Signed-off-by: Cezary Rojewski <[email protected]> Reviewed-on: Reviewed-by: Uzieblo, Olgierd <[email protected]>
Print the firmware version downloaded and verify if it is equal or greater than the minimum supported version for the existing driver. Report error and exit driver initialization if downloaded firmware is not compatible with current driver. Change-Id: I6e0f046d88123c9c216ac9a1c9054f37661e1bfe Signed-off-by: Prakash, Divya1 <[email protected]> Signed-off-by: Mohit Sinha <[email protected]> Signed-off-by: Pardha Saradhi K <[email protected]> Signed-off-by: Amadeusz Sławiński <[email protected]> Reviewed-on: Reviewed-by: Rojewski, Cezary <[email protected]> Tested-by: Rojewski, Cezary <[email protected]>
This patch updates CoE against following change: ALSA: hdac: Remove usage of struct hdac_ext_bus and use hda_bus instead. This patch also fixes NULL dereference panic within soc_dai_hw_params introduced by lastedsoc-framework changes for CoE. Change-Id: I06600e84714863ec37f551ed5373830dec10c29c Signed-off-by: Cezary Rojewski <[email protected]>
…efinition Currently the acpi_generic_address is defined in acrn_common.h. And it is also defined in include/linux/acpi.h. If the two files are included by one driver, it will complain the redefinition of acpi_generic_address. So it is renamed to avoid the redefinition conflict. Signed-off-by: Zhao Yakui <[email protected]>
Set guest ppgtt entry in ppgtt_handle_guest_write_page_table_bytes() Change-Id: Ic6e46561f58eec1a17fb8d5bd9c5dd76d32b5350 Signed-off-by: Min He <[email protected]> Reviewed-on: Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
Refactored BXT plane registers and implemented their plane register handlers. Signed-off-by: Min He <[email protected]> Change-Id: Id72f6aa11db332008b73ce4ad1069386b9b81f35 Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
Change-Id: I4d903a982052b8b241f090a91e2251d66bba2778 Signed-off-by: Min He <[email protected]> Reviewed-on: Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
Added local display dispaly support for GVT-g. Signed-off-by: Min He <[email protected]> Change-Id: I430fbf98318cd35f7104657c4d1c128e50f56f2d Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
This patch includes below features in GVT-g guest 1. DP on port A will be treated as external DP 2. Avoid some unnecessary checks in GVT-g guest 3. initial default vbt values by using PCH_NONE Change-Id: I6f6dfa4e5c801e7a63105310d5991adb0a0acad1 Signed-off-by: Min He <[email protected]> Reviewed-on: Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
Request DomU supports 3 virtual HDMI displays. This requires eDP-1, DP-1 and DP-2 to be disabled on DomU command line. DomU's ias.conf must also be updated to support HDMI and not DP displays. If a panel is not present on port A, DDI B and DDI C will be made active (as in Dom0). Reviewed by: Min He <[email protected]> Signed-off-by: Michael Byrne <[email protected]> Change-Id: Ib944de7bf9be5c19db28d35edd77a9f89148f27a Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
If vgpu is active; a) and we are requesting port A, and a monitor is present on port A, force HDMI initialization (Port A is normally reserved for DP/eDP). b) ignore check for lspcon as this disables HDMI initialiisation if lspcon is supported. c) ignore check for intel_encoder->type != INTEL_OUTPUT_EDP so we can initialise HDMI (HDMI initialization will change the encode type anyway). d) allow HDMI to specify pins for port A to allow initialisation. Change-Id: I99f9636dc6403d67a0de0422eff9b504190fc5f1 Reviewed-by: Min He <[email protected]> Signed-off-by: Michael Byrne <[email protected]> Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
Simple the logic of workload conext status change. Remove the unnecessary status switch when one workload is scheduled in. Signed-off-by: Zhao Yan <[email protected]> Signed-off-by: Zhao Yakui <[email protected]> Signed-off-by: Min He <[email protected]> Change-Id: I509310bf1febb4cd9918440521c29eacad8c06eb Acknowledged-by: Vivek Kasireddy <[email protected]> Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
It's a significant overhead to shadow guest context by copying all the pages, for performance consideration this patch introduce context lazy shadow, it copy the first page of the context only and let the GGTT entries of other shadow context pages point to the corresponding pages of the guest context. Change-Id: I6b806da29fa75eff73122d0328b1a277780eabe1 Signed-off-by: Ping Gao <[email protected]> Acknowledged-by: Singh, Satyeshwar <[email protected]> Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
There are some virtual MMIO registers contains static value which won't be changed by guest writing. Those registers could be optimized with a static value initialization, and do nothing in write handler. Change-Id: I1a85f717ef23c171651f1a1cad5c73880d538e3d Signed-off-by: Pei Zhang <[email protected]> Acknowledged-by: Singh, Satyeshwar <[email protected]> Reviewed-on: Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
This patch add an option in GVTg to disable shadowing wa_ctx. In current IVI environment, since Dom0 and DomU has the same i915, the wa_ctx of them is same. So no need to do shadow copy of wa_ctx. By default, shadowing wa_ctx is disabled. If for testing purpose, people can enable it manually by modifying the code. Change-Id: I535af0a720e7ccfbca80686e45c79c5c2a3dd9c6 Signed-off-by: Min He <[email protected]> Reviewed-by: Singh, Satyeshwar <[email protected]> Reviewed-on: Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
After enabling oos page sync, the loading time of GVT-g guest workload will be reduced. Signed-off-by: Pei Zhang <[email protected]> Reviewed-by: Vivek Kasireddy <[email protected]> Reviewed-by: He, Min <[email protected]> Reviewed-by: Jiang, Fei <[email protected]> Reviewed-by: Dong, Eddie <[email protected]> Tested-by: Dong, Eddie <[email protected]>
gcc 7.3 flagged some iffy if statements with python indentation needing some brackets. this patch adds them. Signed-off-by: mark gross<[email protected]>
Signed-off-by: Tarun Vyas <[email protected]>
Not depending on PCI breaks igb_avb build when building with PCI=n. Follow what other network drivers do in driver/net/ethernet/ for igb_avb too and add "depends on PCI" to the Kconfig. Signed-off-by: Tarun Vyas <[email protected]>
Only create Intel role mux device if the platform has USB peripheral controller device. While here, enable the role mux on Apollo Lake platforms. Signed-off-by: Heikki Krogerus <[email protected]>
We find USB3.0 dwc3 can't work at superspeed on bxtp platform. We setup dwc3 highspeed to enable USB3.0 on bxtp platform. Change-Id: I48df90c39b652f8e2a48598e9e31947e5d68ca17 Tracked-On: Signed-off-by: xiao jin <[email protected]> Signed-off-by: Liu, Alice <[email protected]> Signed-off-by: Greniger, Jacek <[email protected]> (cherry picked from commit 4fc6d0494f0d5f21223c5b3f802a116a757c5893)
In platforms like Cherrytrail, 'SW switch enable' bit should not be enabled for role switch. This patch adds a property to Intel USB Role Switch platform driver to denote that SW switch should be disabled in Cherrytrail devices. Signed-off-by: Saranya Gopal <[email protected]> Signed-off-by: M, Balaji <[email protected]> [ heikki: fixed compile warnings ] Signed-off-by: Heikki Krogerus <[email protected]>
Enable static DRD mode in Intel platforms which guarantees successful role switch all the time. This fixes issues like software role switch failure after cold boot and issue with role switch when 3.0 OTG cable is used. But, do not enable static DRD mode for Cherrytrail devices which rely on firmware for role switch. Signed-off-by: Saranya Gopal <[email protected]> Signed-off-by: M, Balaji <[email protected]> [ heikki: Minor cleanup ] Signed-off-by: Heikki Krogerus <[email protected]>
In dwc3_pci_quirks() function, gpiod lookup table is only registered for baytrail SOC. But in dwc3_pci_remove(), we try to unregistered it without any checks. This leads to NULL pointer de-reference exception in gpiod_remove_lookup_table() when unloading the module. This patch fixes this issue. Signed-off-by: Kuppuswamy Sathyanarayanan <[email protected]>
When battery state is not cached the module parameter cache_time is 0 and battery->update_time starts at 0. However, it set to jiffies in each call to acpi_battery_get_state() and should not be used to determine if a cache time is used. Using battery->update_time causes the evaluation of time_before() even though cache_time is 0. This is a minor issue as the behavior is still as expected. Even if kernel HZ was very slow and jiffies remained equal, the expected branch (false) would be taken because time_before() is used instead of time_before_eq(). Signed-off-by: Lucas Rangit Magasweran <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
Change-Id: I8f77d4f86d5eb2539427291d5ef5254a9a0f3053
Change-Id: I88d3cbbb8c0997e9f6597369e30c6dbb96468c14
Change-Id: Ifffa3e7fe84d0f40912ac4090da4c44419d2e531
Change-Id: I808693cb8d96d7dc0cdfdc5931eee901de64f390
Change-Id: I9fd393ac4aded746aa1c04b7b3e20812269a4b9c
Change-Id: Iea99ad8c13bd2e22c401fdc18b7bc86878104141
Change-Id: Id7dd874fb7d63ec5d8f00690638142e2f38919da
Change-Id: Ia2c694bf1b5e1d26e16bcaf2366d7fc54372b166 Signed-off-by: Gross, Mark <[email protected]>
Change-Id: I00e80c635722285048ed0afd4a200f3401b085e3
Change-Id: I4bb2e9d6157f25b7ce5a62d7d80c3beff4076e37 Signed-off-by: Gross, Mark <[email protected]>
Change-Id: I70c131e6aa1323a0ba352fc8fc0dbd79c51dc685
Change-Id: I1d231bb145d689c0cd7829ea27cf839cf8dab5fa Signed-off-by: Gross, Mark <[email protected]>
Change-Id: I8665ca44c7415aa98c77ce826aad303097858b6c
…19/mainline-tracking-rc7.3 * commit 'c6537958be5c81c9ffe17a166d9dc0ad0b631e49': (545 commits) ACPI: battery: use cache_time as cache "enabled" usb: dwc3: Fix NULL pointer exception in dwc3_pci_remove() roles: Enable static DRD mode for role switch in Intel platforms xhci-ext-caps.c: Add property to disable SW switch [REVERTME] dwc3 setup highspeed to USB3.0 on bxtp platform usb: xhci: pci: Only create Intel mux device when it's needed staging: igb_avb: Add PCI dependency to igb_avb Kconfig staging: igb_avb: Remove non-UTF chars to unbreak scripts fix some likely copy paste errors with some if blocks the igb_avb direver cannot coexist with e1000 or e1000e drivers. staging: Add AVnu based Intel IGB driver Fix for cbc kernel driver crash during warm reboot cbc: Avoid rx sequence counter mismatch warnings Integration of CBC line discipline kernel module x86/mm/cpa: Avoid the 4k pages check completely x86/mm/cpa: Do the range check early x86/mm/cpa: Optimize same protection check x86/mm/cpa: Add sanity check for existing mappings x86/mm/cpa: Avoid static protection checks on unmap x86/mm/cpa: Add large page preservation statistics ...
…19/mainline-tracking-android-rc7.3 * commit '14aa0f14d2c3150c16fa417558fec35edbcc41e8': (557 commits) Fix compilation errors when rebase to v4.19-rc1. check return value of hypercall Fix compile warning from ISO90 and output format register suspend callback refine work queue in trusty driver Revert "trusty-ipc: change DEFAULT_MSG_BUF_SIZE to 68K" unify trusty driver trusty: Update macro SMC_FC_GET_WALL_SIZE from 12 to 20 trusty: add RAX into clobber list of inline asm for ACRN trusty: Rename CWP with ACRN trusty: Update dependency of trusty module Remove unused label to depress compile warning trusty: detect vmm when load trusty driver trusty: Update Trusty timer solution trusty: Check if eVmm is available before init driver trusty: Add null check pointer before deference Change Trusty Kconfig to build for X86 Arch only trusty kernel driver code refine trusty: add support for trusty backup timer trusty: add support for SM Wall object ...
in commercial nuc Tracked-On: None Signed-off-by: M,Balaji <[email protected]>
swaroopbalan
pushed a commit
that referenced
this pull request
Jul 9, 2019
[ Upstream commit 4d8e3e951a856777720272ce27f2c738a3eeef8c ]
During early system resume on Exynos5422 with performance counters enabled
the following kernel oops happens:
Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP ARM
Modules linked in:
CPU: 0 PID: 1433 Comm: bash Tainted: G W 5.0.0-rc5-next-20190208-00023-gd5fb5a8a13e6-dirty #5480
Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
...
Flags: nZCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment none
Control: 10c5387d Table: 4451006a DAC: 00000051
Process bash (pid: 1433, stack limit = 0xb7e0e22f)
...
(reset_ctrl_regs) from [<c0112ad0>] (dbg_cpu_pm_notify+0x1c/0x24)
(dbg_cpu_pm_notify) from [<c014c840>] (notifier_call_chain+0x44/0x84)
(notifier_call_chain) from [<c014cbc0>] (__atomic_notifier_call_chain+0x7c/0x128)
(__atomic_notifier_call_chain) from [<c01ffaac>] (cpu_pm_notify+0x30/0x54)
(cpu_pm_notify) from [<c055116c>] (syscore_resume+0x98/0x3f4)
(syscore_resume) from [<c0189350>] (suspend_devices_and_enter+0x97c/0xe74)
(suspend_devices_and_enter) from [<c0189fb8>] (pm_suspend+0x770/0xc04)
(pm_suspend) from [<c0187740>] (state_store+0x6c/0xcc)
(state_store) from [<c09fa698>] (kobj_attr_store+0x14/0x20)
(kobj_attr_store) from [<c030159c>] (sysfs_kf_write+0x4c/0x50)
(sysfs_kf_write) from [<c0300620>] (kernfs_fop_write+0xfc/0x1e0)
(kernfs_fop_write) from [<c0282be8>] (__vfs_write+0x2c/0x160)
(__vfs_write) from [<c0282ea4>] (vfs_write+0xa4/0x16c)
(vfs_write) from [<c0283080>] (ksys_write+0x40/0x8c)
(ksys_write) from [<c0101000>] (ret_fast_syscall+0x0/0x28)
Undefined instruction is triggered during CP14 reset, because bits: #16
(Secure privileged invasive debug disabled) and #17 (Secure privileged
noninvasive debug disable) are set in DSCR. Those bits depend on SPNIDEN
and SPIDEN lines, which are provided by Secure JTAG hardware block. That
block in turn is powered from cluster 0 (big/Eagle), but the Exynos5422
boots on cluster 1 (LITTLE/KFC).
To fix this issue it is enough to turn on the power on the cluster 0 for
a while. This lets the Secure JTAG block to propagate the needed signals
to LITTLE/KFC cores and change their DSCR.
Signed-off-by: Marek Szyprowski <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
swaroopbalan
pushed a commit
that referenced
this pull request
Jul 31, 2019
[ Upstream commit 04e03d9a616c19a47178eaca835358610e63a1dd ] The mapper may be NULL when called from register_ftrace_function_probe() with probe->data == NULL. This issue can be reproduced as follow (it may be covered by compiler optimization sometime): / # cat /sys/kernel/debug/tracing/set_ftrace_filter #### all functions enabled #### / # echo foo_bar:dump > /sys/kernel/debug/tracing/set_ftrace_filter [ 206.949100] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 206.952402] Mem abort info: [ 206.952819] ESR = 0x96000006 [ 206.955326] Exception class = DABT (current EL), IL = 32 bits [ 206.955844] SET = 0, FnV = 0 [ 206.956272] EA = 0, S1PTW = 0 [ 206.956652] Data abort info: [ 206.957320] ISV = 0, ISS = 0x00000006 [ 206.959271] CM = 0, WnR = 0 [ 206.959938] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000419f3a000 [ 206.960483] [0000000000000000] pgd=0000000411a87003, pud=0000000411a83003, pmd=0000000000000000 [ 206.964953] Internal error: Oops: 96000006 [#1] SMP [ 206.971122] Dumping ftrace buffer: [ 206.973677] (ftrace buffer empty) [ 206.975258] Modules linked in: [ 206.976631] Process sh (pid: 281, stack limit = 0x(____ptrval____)) [ 206.978449] CPU: 10 PID: 281 Comm: sh Not tainted 5.2.0-rc1+ #17 [ 206.978955] Hardware name: linux,dummy-virt (DT) [ 206.979883] pstate: 60000005 (nZCv daif -PAN -UAO) [ 206.980499] pc : free_ftrace_func_mapper+0x2c/0x118 [ 206.980874] lr : ftrace_count_free+0x68/0x80 [ 206.982539] sp : ffff0000182f3ab0 [ 206.983102] x29: ffff0000182f3ab0 x28: ffff8003d0ec1700 [ 206.983632] x27: ffff000013054b40 x26: 0000000000000001 [ 206.984000] x25: ffff00001385f000 x24: 0000000000000000 [ 206.984394] x23: ffff000013453000 x22: ffff000013054000 [ 206.984775] x21: 0000000000000000 x20: ffff00001385fe28 [ 206.986575] x19: ffff000013872c30 x18: 0000000000000000 [ 206.987111] x17: 0000000000000000 x16: 0000000000000000 [ 206.987491] x15: ffffffffffffffb0 x14: 0000000000000000 [ 206.987850] x13: 000000000017430e x12: 0000000000000580 [ 206.988251] x11: 0000000000000000 x10: cccccccccccccccc [ 206.988740] x9 : 0000000000000000 x8 : ffff000013917550 [ 206.990198] x7 : ffff000012fac2e8 x6 : ffff000012fac000 [ 206.991008] x5 : ffff0000103da588 x4 : 0000000000000001 [ 206.991395] x3 : 0000000000000001 x2 : ffff000013872a28 [ 206.991771] x1 : 0000000000000000 x0 : 0000000000000000 [ 206.992557] Call trace: [ 206.993101] free_ftrace_func_mapper+0x2c/0x118 [ 206.994827] ftrace_count_free+0x68/0x80 [ 206.995238] release_probe+0xfc/0x1d0 [ 206.995555] register_ftrace_function_probe+0x4a8/0x868 [ 206.995923] ftrace_trace_probe_callback.isra.4+0xb8/0x180 [ 206.996330] ftrace_dump_callback+0x50/0x70 [ 206.996663] ftrace_regex_write.isra.29+0x290/0x3a8 [ 206.997157] ftrace_filter_write+0x44/0x60 [ 206.998971] __vfs_write+0x64/0xf0 [ 206.999285] vfs_write+0x14c/0x2f0 [ 206.999591] ksys_write+0xbc/0x1b0 [ 206.999888] __arm64_sys_write+0x3c/0x58 [ 207.000246] el0_svc_common.constprop.0+0x408/0x5f0 [ 207.000607] el0_svc_handler+0x144/0x1c8 [ 207.000916] el0_svc+0x8/0xc [ 207.003699] Code: aa0003f8 a9025bf5 aa0103f5 f946ea80 (f9400303) [ 207.008388] ---[ end trace 7b6d11b5f542bdf1 ]--- [ 207.010126] Kernel panic - not syncing: Fatal exception [ 207.011322] SMP: stopping secondary CPUs [ 207.013956] Dumping ftrace buffer: [ 207.014595] (ftrace buffer empty) [ 207.015632] Kernel Offset: disabled [ 207.017187] CPU features: 0x002,20006008 [ 207.017985] Memory Limit: none [ 207.019825] ---[ end Kernel panic - not syncing: Fatal exception ]--- Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Wei Li <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in commercial nuc
Tracked-On: None
Signed-off-by: M,Balaji [email protected]