Fix duplicate annotations in Eclipse when copying Jackson annotations #3963
+190
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please review this PR? The problem affects vscode-java (as it runs a version of Eclipse JDT under the hood) |
+1 a retro-compatible fix is highly welcome for all the vscoders trying to do some java |
|
Please review this contribution from the community. Sorry to tag committers directly but Lombok in Eclipse-based and VS Code IDEs is broken without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by #3860: With
lombok.copyJacksonAnnotationsToAccessors = true, some annotation are copied twice in Eclipse, resulting in the compilation error "@XYZ is not a repeatable annotation".Fixes #3934.