(bug) EventReport deletion #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting stale EventReports, always pass the EventSource. Removing EventReports for a given cluster without passing the EventSource name causes all EventReports to be removed, which particularly affect EventReports with CloudEvents which are then lost for good. This PR fixes that. This PR also improves the hash evaluation making stabler and so causing less un-necessary reconciliations. (bug) When EventTrigger hash changes, resets the EventReport status This allows, EventTrigger to re-update ClusterProfiles. ClusterProfiles are otherwise only updated when EventReport changes. This PR also makes sure that when event-manager restarts, the very first time all EventReports are re-processed. After that, an EventReport instance is reprocessed only if: - EventReport changes, which is detected during eventReport collection - EventTrigger hash changes (which triggers event-manager to reset the EventReport status)
gianlucam76
force-pushed
the
cloudevents-agentless
branch
from
ab82b81 to
1e03908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting stale EventReports, always pass the EventSource. Removing EventReports for a given cluster without passing the EventSource name causes all EventReports to be removed, which particularly affect EventReports with CloudEvents which are then lost for good.
This PR fixes that.
This PR also improves the hash evaluation making stabler and so causing less un-necessary reconciliations.
(bug) When EventTrigger hash changes, resets the EventReport status
This allows, EventTrigger to re-update ClusterProfiles.
ClusterProfiles are otherwise only updated when EventReport changes.
This PR also makes sure that when event-manager restarts, the very first
time all EventReports are re-processed.
After that, an EventReport instance is reprocessed only if:
EventReport status)