[kube-prometheus-stack] Add the possibility to specify matchConditions for admissionWebhooks objects #5723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects Signed-off-by: Maurits Monteyne <[email protected]>
MauritsMonteyne
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks,
jkroepke and
scottrigby
as code owners
Member
|
This looks like a good improvement |
QuentinBisson
approved these changes
Jun 2, 2025
Contributor
Author
|
Thanks a lot! |
1 task
This was referenced Aug 18, 2025
Closed
Closed
Closed
feat(container)!: Update image kube-prometheus-stack to v76 - autoclosed
martinjonsson01/cluster#642
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add the possibility to specify
matchConditionsfor admissionWebhooks objects. We have a use case where we don't want validation for some of our Prometheus rules. Currently,matchLabelsallows filtering based on label presence, but there is no built-in way to exclude certain labels. AddingmatchConditionswould solve this problem by letting us define more flexible filtering logic.Which issue this PR fixes
N/A
Special notes for your reviewer
N/A
Checklist
[prometheus-couchdb-exporter])