feat: support setting ICMP source address for outgoing packets #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snormore
force-pushed
the
snor/pin-source
branch
from
774d6bd to
963180e
Compare
SuperQ
reviewed
Oct 23, 2025
SuperQ
requested changes
Oct 23, 2025
SuperQ
reviewed
Oct 23, 2025
|
Thanks @SuperQ - I pushed those updates in new commits. If it looks good I can squash them into the original commit and fix the DCO CI failure. |
Previously, the source IP for ICMP echo requests was determined by system routing. This change applies the Pinger.Source value—already used when binding the socket—to outgoing control messages as well, allowing users to specify which local address ICMP packets originate from. This is useful on multi-interface systems or when testing routing behavior from specific local addresses. Signed-off-by: Steven Normore <[email protected]>
snormore
force-pushed
the
snor/pin-source
branch
from
115519f to
3244b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for explicitly setting the ICMP source address when sending ping requests. Previously, the source IP was determined by system routing; with this change, the existing
Pinger.Sourcefield (already used for binding) is also applied to outgoing packets, allowing control over which local address is used.Motivation
On systems with multiple interfaces or addresses, it’s often useful to choose the source IP for ICMP echo requests—for example, to test reachability or routing behavior from a specific interface. This change makes the
Sourcefield consistent across bind and send operations.Example
This sends ICMP packets using
192.168.1.10as the source.