Skip to content

Conversation

@slrtbtfs
Copy link
Member

@slrtbtfs slrtbtfs commented Jul 17, 2020

Fixes #189.

This fixes some unchecked pointer accesses in the rest package.

Independently of how errors are handled, these checks should be in place.

Proper error handling as discussed in #189 and #190 can happen separately.

Signed-off-by: Tobias Guggenmos [email protected]

Fixes #189.

This fixes some unchecked pointer accesses in the cache package.

Independently of how errors are handled, these checks should be in place.

Proper error handling as discussed in #189 and #181 can happen separately.

Signed-off-by: Tobias Guggenmos <[email protected]>
@slrtbtfs slrtbtfs requested a review from Nexucis July 17, 2020 19:00
@slrtbtfs
Copy link
Member Author

slrtbtfs commented Jul 17, 2020

To be clear, merging this PR doesn't mean #190 won't be merged, once it's ready.

#190 does a different thing and addresses a wider issue.

Copy link
Contributor

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nexucis Nexucis merged commit 76204d7 into master Jul 17, 2020
@Nexucis Nexucis deleted the nil-pointers branch July 17, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected dead of HTTP request for completion endpoint

3 participants