fix logsumexp and add a test #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 81.36% 81.25% -0.11%
==========================================
Files 90 90
Lines 18274 18148 -126
Branches 18274 18148 -126
==========================================
- Hits 14868 14746 -122
- Misses 3281 3302 +21
+ Partials 125 100 -25 ☔ View full report in Codecov by Sentry. |
BaxterEaves
requested changes
Jan 8, 2025
Contributor
BaxterEaves
left a comment
BaxterEaves
left a comment
There was a problem hiding this comment.
Thanks -- looks good. Only request is to please add an entry to the Changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.