More demo hotfix #1871
Draft
More demo hotfix #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bundle-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This hotfix streamlines configuration formatting across packages, adjusts TypeScript typesVersions, and cleans up the frictionless CAPTCHA demo HTML by removing duplicated markup and setting up explicit rendering.
- Unify
browserslistformatting in allpackage.jsonfiles - Simplify
typesVersionsarrays in the datasets package - Refactor
frictionless-implicit.htmldemo: remove duplicate sections, restructure script, and userender
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/procaptcha-react/package.json | Inline browserslist array formatting |
| packages/procaptcha-pow/package.json | Inline browserslist array formatting |
| packages/procaptcha-frictionless/package.json | Inline browserslist array formatting |
| packages/procaptcha-common/package.json | Inline browserslist array formatting |
| packages/procaptcha-bundle/package.json | Inline browserslist array formatting |
| packages/datasets/package.json | Simplify typesVersions to inline arrays |
| demos/client-bundle-example/src/frictionless-implicit.html | Remove duplicate HTML, consolidate scripts, use render |
| .changeset/odd-frogs-type.md | Add patch-level changeset for lint hotfix |
Comments suppressed due to low confidence (1)
demos/client-bundle-example/src/frictionless-implicit.html:33
- The inline onclick handler calls
onActionHandler(), but this function is not defined in the script, leading to a runtime error. Define the handler or remove the attribute.
<button type="button" class="mui-btn mui-btn--raised" onclick="onActionHandler()" data-cy="submit-button">Submit</button>
| <script type="module"> | ||
| // Pattern to avoid race condition between Procaptcha script loading and Procaptcha render function call | ||
| import { render } from "%VITE_BUNDLE_URL%" | ||
| import { render } from "%VITE_BUNDLE_URL%" // Replace with the actual bundle URL |
There was a problem hiding this comment.
[nitpick] Add a semicolon at the end of the import statement to follow consistent JavaScript syntax.
Suggested change
| import { render } from "%VITE_BUNDLE_URL%" // Replace with the actual bundle URL | |
| import { render } from "%VITE_BUNDLE_URL%"; // Replace with the actual bundle URL |
|
|
||
| window.updateCaptchaStatus('CAPTCHA render function called with widget ID: ' + widgetId, 'info'); | ||
|
|
||
| // The rest of this |
There was a problem hiding this comment.
[nitpick] This comment appears incomplete and should be removed or clarified to avoid confusion.
Suggested change
| // The rest of this |
auto-merge was automatically disabled
July 29, 2025 09:29
Pull request was converted to draft
forgetso
force-pushed
the
More-demo-hotfix
branch
from
1c78d0d to
c5a1e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.