Mark mutable repeated fields/maps as [[nodiscard]] #24476
Draft
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these fields have implicit presence, these are no-ops if the returned pointer is unused. These are logically constant, but named "mutable_..." and are non-const methods of the class in order to return the non-const references. Ignoring the return value likely indicates an omission on the part of the caller, an error by confusing it with explicit presence fields (like scalar submessages or strings), or a call that can be cleaned up. PiperOrigin-RevId: 832394000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark mutable repeated fields/maps as [[nodiscard]]
Since these fields have implicit presence, these are no-ops if the returned
pointer is unused. These are logically constant, but named "mutable_..." and
are non-const methods of the class in order to return the non-const references.
Ignoring the return value likely indicates an omission on the part of the
caller, an error by confusing it with explicit presence fields (like scalar
submessages or strings), or a call that can be cleaned up.